Attachment 372292 Details for Bug 198937 – Patch

[patch] Patch

bug-198937-20190617163331.patch (text/plain), 7.33 KB, created by Devin Rousso on 2019-06-17 16:33:32 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-06-17 16:33:32 PDT

Size: 7.33 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 079cf01a7766fee345c357b9489642eb5f01ccba..f842d82b918f62f6d8cf2fe4cfcfc59f54e00d0c 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,21 @@
>+2019-06-17  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Elements: add/edit/copy/delete menus should have a "..." in the label
>+        https://bugs.webkit.org/show_bug.cgi?id=198937
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This matches the "Break on..." menu and makes it even clearer that you're supposed to
>+        click on one of the items in the submenu in order for anything to happen.
>+
>+        * UserInterface/Views/DOMTreeOutline.js:
>+        (WI.DOMTreeOutline.prototype.populateContextMenu):
>+
>+        * UserInterface/Views/ContextMenuUtilities.js:
>+        (WI.appendContextMenuItemsForDOMNode):
>+
>+        * Localizations/en.lproj/localizedStrings.js:
>+
> 2019-06-17  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Settings: split the General panel into sub panels so it's less crowded
>diff --git a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>index de79b54aba82457e9eb7b98c438088b0730b4062..0271c7fdacdd5fe37c29485babf351ab2bc105b2 100644
>--- a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>+++ b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>@@ -81,7 +81,6 @@ localizedStrings["2D"] = "2D";
> localizedStrings["Accessibility"] = "Accessibility";
> localizedStrings["Action"] = "Action";
> localizedStrings["Activity Viewer"] = "Activity Viewer";
>-localizedStrings["Add"] = "Add";
> localizedStrings["Add Action"] = "Add Action";
> localizedStrings["Add Breakpoint"] = "Add Breakpoint";
> localizedStrings["Add New"] = "Add New";
>@@ -93,6 +92,7 @@ localizedStrings["Add new breakpoint action after this action"] = "Add new break
> localizedStrings["Add new rule"] = "Add new rule";
> localizedStrings["Add probe expression"] = "Add probe expression";
> localizedStrings["Add watch expression"] = "Add watch expression";
>+localizedStrings["Add\u2026"] = "Add\u2026";
> localizedStrings["Additions"] = "Additions";
> localizedStrings["Address"] = "Address";
> localizedStrings["All"] = "All";
>@@ -289,6 +289,7 @@ localizedStrings["Copy Row"] = "Copy Row";
> localizedStrings["Copy Selected"] = "Copy Selected";
> localizedStrings["Copy Table"] = "Copy Table";
> localizedStrings["Copy as cURL"] = "Copy as cURL";
>+localizedStrings["Copy\u2026"] = "Copy\u2026";
> localizedStrings["Could not fetch properties. Object may no longer exist."] = "Could not fetch properties. Object may no longer exist.";
> localizedStrings["Count"] = "Count";
> localizedStrings["Create Breakpoint"] = "Create Breakpoint";
>@@ -323,6 +324,7 @@ localizedStrings["Default"] = "Default";
> localizedStrings["Delete"] = "Delete";
> localizedStrings["Delete Breakpoint"] = "Delete Breakpoint";
> localizedStrings["Delete Breakpoints"] = "Delete Breakpoints";
>+localizedStrings["Delete\u2026"] = "Delete\u2026";
> localizedStrings["Demo Audit"] = "Demo Audit";
> localizedStrings["Detach into separate window"] = "Detach into separate window";
> localizedStrings["Detached"] = "Detached";
>@@ -369,6 +371,7 @@ localizedStrings["Edit \u201Ccubic-bezier\u201D function"] = "Edit \u201Ccubic-b
> localizedStrings["Edit \u201Cspring\u201D function"] = "Edit \u201Cspring\u201D function";
> localizedStrings["Edit configuration"] = "Edit configuration";
> localizedStrings["Edit custom gradient"] = "Edit custom gradient";
>+localizedStrings["Edit\u2026"] = "Edit\u2026";
> localizedStrings["Editing audits"] = "Editing audits";
> localizedStrings["Element"] = "Element";
> localizedStrings["Element Selection:"] = "Element Selection:";
>@@ -489,10 +492,10 @@ localizedStrings["Fonts"] = "Fonts";
> localizedStrings["Force Dark Appearance"] = "Force Dark Appearance";
> localizedStrings["Force Light Appearance"] = "Force Light Appearance";
> localizedStrings["Force Print Media Styles"] = "Force Print Media Styles";
>+/* A context menu item to force (override) a DOM node's pseudo-classes */
>+localizedStrings["Force Pseudo-Class\u2026"] = "Force Pseudo-Class\u2026";
> /* Layout phase records that were imperative (forced) */
> localizedStrings["Forced Layout"] = "Forced Layout";
>-/* A context menu item to force (override) a DOM node's pseudo-classes */
>-localizedStrings["Forced Pseudo-Classes"] = "Forced Pseudo-Classes";
> localizedStrings["Format: HSL"] = "Format: HSL";
> localizedStrings["Format: HSLA"] = "Format: HSLA";
> localizedStrings["Format: Hex"] = "Format: Hex";
>diff --git a/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js b/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js
>index da3dc633cdfcac6c0dcc703a867d4037156d6788..70174b86ecbd1e02f3f3b7f02cdadf95f6c52771 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js
>@@ -153,7 +153,7 @@ WI.appendContextMenuItemsForDOMNode = function(contextMenu, domNode, options = {
>     if (!(domNode instanceof WI.DOMNode))
>         return;
> 
>-    let copySubMenu = options.copySubMenu || contextMenu.appendSubMenuItem(WI.UIString("Copy"));
>+    let copySubMenu = options.copySubMenu || contextMenu.appendSubMenuItem(WI.UIString("Copy\u2026"));
> 
>     let isElement = domNode.nodeType() === Node.ELEMENT_NODE;
>     let attached = domNode.attached;
>@@ -210,7 +210,7 @@ WI.appendContextMenuItemsForDOMNode = function(contextMenu, domNode, options = {
>     if (WI.cssManager.canForcePseudoClasses() && domNode.attached) {
>         contextMenu.appendSeparator();
> 
>-        let pseudoSubMenu = contextMenu.appendSubMenuItem(WI.UIString("Forced Pseudo-Classes", "A context menu item to force (override) a DOM node's pseudo-classes"));
>+        let pseudoSubMenu = contextMenu.appendSubMenuItem(WI.UIString("Force Pseudo-Class\u2026", "A context menu item to force (override) a DOM node's pseudo-classes"));
> 
>         let enabledPseudoClasses = domNode.enabledPseudoClasses;
>         WI.CSSManager.ForceablePseudoClasses.forEach((pseudoClass) => {
>diff --git a/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js b/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js
>index 404075d7b9e1fb5e558c74b4f183612a4878d543..196c6e68072b97a4149fcb8b2e169c75991d8e96 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js
>@@ -273,10 +273,10 @@ WI.DOMTreeOutline = class DOMTreeOutline extends WI.TreeOutline
>     populateContextMenu(contextMenu, event, treeElement)
>     {
>         let subMenus = {
>-            add: new WI.ContextSubMenuItem(contextMenu, WI.UIString("Add")),
>-            edit: new WI.ContextSubMenuItem(contextMenu, WI.UIString("Edit")),
>-            copy: new WI.ContextSubMenuItem(contextMenu, WI.UIString("Copy")),
>-            delete: new WI.ContextSubMenuItem(contextMenu, WI.UIString("Delete")),
>+            add: new WI.ContextSubMenuItem(contextMenu, WI.UIString("Add\u2026")),
>+            edit: new WI.ContextSubMenuItem(contextMenu, WI.UIString("Edit\u2026")),
>+            copy: new WI.ContextSubMenuItem(contextMenu, WI.UIString("Copy\u2026")),
>+            delete: new WI.ContextSubMenuItem(contextMenu, WI.UIString("Delete\u2026")),
>         };
> 
>         if (treeElement.selected && this.selectedTreeElements.length > 1)

Flags:

mattbaker: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 198937: 372290 | 372292 | 372293