Attachment 372282 Details for Bug 198936 – Patch

[patch] Patch

bug-198936-20190617155358.patch (text/plain), 1.48 KB, created by Megan Gardner on 2019-06-17 15:53:58 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Megan Gardner

Created: 2019-06-17 15:53:58 PDT

Size: 1.48 KB

patch

obsolete

>Subversion Revision: 246513
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 6eda6bcfc378e91c01e416fce3385ff44cf157a2..eedd0dfb781b3abf2e18ba970345b66a77671458 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-06-17  Megan Gardner  <megan_gardner@apple.com>
>+
>+        Dismiss Calloutbar when text is entered
>+        https://bugs.webkit.org/show_bug.cgi?id=198936
>+        <rdar://problem/51075196>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The callout bar incorrectly stays visible when typing text.
>+        Any text insertion should dismiss it.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView insertText:]):
>+
> 2019-06-17  Tim Horton  <timothy_horton@apple.com>
> 
>         Fix the build.
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index 62b3ae19877aaa18458baa34d8e4ddcd532aea78..fedd5716d913aebda684c916b1f1e6c2295e176c 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -4255,6 +4255,7 @@ - (void)insertText:(NSString *)aStringValue
>     WebKit::InsertTextOptions options;
>     options.processingUserGesture = [keyboard respondsToSelector:@selector(isCallingInputDelegate)] && keyboard.isCallingInputDelegate;
> 
>+    [UICalloutBar fadeSharedCalloutBar];
>     _page->insertTextAsync(aStringValue, WebKit::EditingRange(), WTFMove(options));
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198936: 372282