Attachment 372277 Details for Bug 198934 – Patch

[patch] Patch

patch198934 (text/plain), 1.76 KB, created by Robin Morisset on 2019-06-17 15:16:28 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Robin Morisset

Created: 2019-06-17 15:16:28 PDT

Size: 1.76 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 94711c2ba76..e6831907b51 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-06-17  Robin Morisset  <rmorisset@apple.com>
>+
>+        [WHLSL] Remove backtracking from parseAttributeBlock
>+        https://bugs.webkit.org/show_bug.cgi?id=198934
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No functional change intended.
>+
>+        Tested by running LayoutTests/webgpu/whlsl-compute.html
>+
>+        * Modules/webgpu/WHLSL/WHLSLParser.cpp:
>+        (WebCore::WHLSL::Parser::parseAttributeBlock):
>+
> 2019-06-17  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r246501.
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp
>index 6ef34da56a2..4fa5c6e65ee 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp
>@@ -854,19 +854,12 @@ auto Parser::parseAttributeBlock() -> Expected<AST::AttributeBlock, Error>
>     AST::AttributeBlock result;
> 
>     while (true) {
>-        auto numThreadsFunctionAttribute = backtrackingScope<Expected<AST::NumThreadsFunctionAttribute, Error>>([&]() {
>-            return parseNumThreadsFunctionAttribute();
>-        });
>-        if (numThreadsFunctionAttribute) {
>-            result.append(WTFMove(*numThreadsFunctionAttribute));
>-            continue;
>-        }
>-
>-        break;
>+        if (tryType(Lexer::Token::Type::RightSquareBracket))
>+            break;
>+        PARSE(numThreadsFunctionAttribute, NumThreadsFunctionAttribute);
>+        result.append(WTFMove(*numThreadsFunctionAttribute));
>     }
> 
>-    CONSUME_TYPE(rightSquareBracket, RightSquareBracket);
>-
>     return WTFMove(result);
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198934: 372277