Attachment 372269 Details for Bug 198931 – Revert r245965

[patch] Revert r245965

file_198931.txt (text/plain), 1.58 KB, created by mitz on 2019-06-17 13:52:36 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: mitz

Created: 2019-06-17 13:52:36 PDT

Size: 1.58 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 246514)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2019-06-17  Dan Bernstein  <mitz@apple.com>
>+
>+        Revert workaround for bug 198904 from run-webkit-archive
>+        https://bugs.webkit.org/show_bug.cgi?id=198931
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Reverted r245965, now that the load commands in the XPC service binaries make them correctly
>+        pick up the built frameworks.
>+
>+        * WebKitArchiveSupport/run-webkit-archive:
>+        (set_dyld_framework_path):
>+
> 2019-06-17  Jiewen Tan  <jiewen_tan@apple.com>
> 
>         Move SOAuthorization from WebKitAdditions to WebKit
>Index: Tools/WebKitArchiveSupport/run-webkit-archive
>===================================================================
>--- Tools/WebKitArchiveSupport/run-webkit-archive	(revision 246514)
>+++ Tools/WebKitArchiveSupport/run-webkit-archive	(working copy)
>@@ -54,8 +54,6 @@ def set_dyld_framework_path(script_path)
>     print('Setting DYLD FRAMEWORK and LIBRARY paths to {}'.format(dyld_path))
>     os.environ['DYLD_FRAMEWORK_PATH'] = dyld_path
>     os.environ['DYLD_LIBRARY_PATH'] = dyld_path
>-    os.environ['__XPC_DYLD_FRAMEWORK_PATH'] = dyld_path
>-    os.environ['__XPC_DYLD_LIBRARY_PATH'] = dyld_path
>     
> def main():
>     check_for_valid_platform()
>@@ -68,4 +66,4 @@ if __name__ == '__main__':
>     try:
>         main()    
>     except KeyboardInterrupt:
>-        exit("Aborting.")
>+        exit("Aborting.")
>\ No newline at end of file

Actions: View | Formatted Diff | Diff

Attachments on bug 198931: 372269