Attachment 372268 Details for Bug 198922 – Simpler fix, but no insurance policy.... let's see what happens.

[patch] Simpler fix, but no insurance policy.... let's see what happens.

SimpleFixNoInsurancePolicy.diff (text/plain), 1.07 KB, created by Daniel Bates on 2019-06-17 13:39:37 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2019-06-17 13:39:37 PDT

Size: 1.07 KB

patch

obsolete

>From 9f100242b9b1861a1b26d38ca1ee5df79a6ee0ae Mon Sep 17 00:00:00 2001
>From: Daniel Bates <dabates@apple.com>
>Date: Mon, 17 Jun 2019 13:37:26 -0700
>Subject: [PATCH] Simpler fix... can we get away with it?
>
>---
> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>index 9f702b01c23..38e1060ffbe 100644
>--- a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>+++ b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>@@ -2587,9 +2587,6 @@ static void selectionPositionInformation(WebPage& page, const InteractionInforma
>         return;
> 
>     RenderObject* renderer = hitNode->renderer();
>-    if (!request.readonly)
>-        page.corePage()->focusController().setFocusedFrame(result.innerNodeFrame());
>-
>     info.bounds = renderer->absoluteBoundingBoxRect(true);
>     // We don't want to select blocks that are larger than 97% of the visible area of the document.
>     if (is<HTMLAttachmentElement>(*hitNode)) {
>-- 
>2.21.0 (Apple Git-118)
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198922: 372253 | 372262 | 372268 | 372374 | 372386