Attachment 372264 Details for Bug 198929 – WIP

[patch] WIP

bug-198929-20190617211619.patch (text/plain), 1.43 KB, created by Zan Dobersek on 2019-06-17 12:16:20 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Zan Dobersek

Created: 2019-06-17 12:16:20 PDT

Size: 1.43 KB

patch

obsolete

>Subversion Revision: 246494
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 4de04ad71fdb3e85823afea2d51e62a8dba7e448..0a562e03445b1b13479f191d9792f45ba591b8f4 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-06-17  Zan Dobersek  <zdobersek@igalia.com>
>+
>+        [WebGL] Extensions3DOpenGLES::bindVertexArrayOES() should allow zero array object
>+        https://bugs.webkit.org/show_bug.cgi?id=198929
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests (OOPS!).
>+
>+        * platform/graphics/opengl/Extensions3DOpenGLES.cpp:
>+        (WebCore::Extensions3DOpenGLES::bindVertexArrayOES):
>+
> 2019-06-17  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Unreviewed, rolling out r246467.
>diff --git a/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp b/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp
>index b032ed7fc2f4095f38eecbdbede975c6a98e8e11..b2b4b03d5ebc5c2c39e7be4940d965c902955b7c 100644
>--- a/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp
>+++ b/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp
>@@ -167,9 +167,6 @@ GC3Dboolean Extensions3DOpenGLES::isVertexArrayOES(Platform3DObject array)
> 
> void Extensions3DOpenGLES::bindVertexArrayOES(Platform3DObject array)
> {
>-    if (!array)
>-        return;
>-
>     m_context->makeContextCurrent();
>     if (m_glBindVertexArrayOES)
>         m_glBindVertexArrayOES(array);

Actions: View | Formatted Diff | Diff

Attachments on bug 198929: 372264 | 372333