WebKit Bugzilla
Attachment 372258 Details for
Bug 198926
: Add null check in WebFrameLoaderClient::assignIdentifierToInitialRequest
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-198926-20190617112420.patch (text/plain), 1.59 KB, created by
Alex Christensen
on 2019-06-17 11:24:21 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Alex Christensen
Created:
2019-06-17 11:24:21 PDT
Size:
1.59 KB
patch
obsolete
>Index: Source/WebKit/ChangeLog >=================================================================== >--- Source/WebKit/ChangeLog (revision 246500) >+++ Source/WebKit/ChangeLog (working copy) >@@ -1,3 +1,15 @@ >+2019-06-17 Alex Christensen <achristensen@webkit.org> >+ >+ Add null check in WebFrameLoaderClient::assignIdentifierToInitialRequest >+ https://bugs.webkit.org/show_bug.cgi?id=198926 >+ <rdar://problem/50079713> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: >+ (WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest): >+ WebKitLegacy's version already checks null for the corresponding call. >+ > 2019-06-17 Brent Fulgham <bfulgham@apple.com> > > Ensure ITP state is relayed to Network Process on restart >Index: Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp >=================================================================== >--- Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (revision 246135) >+++ Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (working copy) >@@ -197,7 +197,7 @@ void WebFrameLoaderClient::assignIdentif > return; > > bool pageIsProvisionallyLoading = false; >- if (FrameLoader* frameLoader = loader->frameLoader()) >+ if (FrameLoader* frameLoader = loader ? loader->frameLoader() : nullptr) > pageIsProvisionallyLoading = frameLoader->provisionalDocumentLoader() == loader; > > webPage->injectedBundleResourceLoadClient().didInitiateLoadForResource(*webPage, *m_frame, identifier, request, pageIsProvisionallyLoading);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 198926
: 372258