Attachment 372253 Details for Bug 198922 – For the Bots

[patch] For the Bots

ForTheBots.patch (text/plain), 2.00 KB, created by Daniel Bates on 2019-06-17 10:26:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2019-06-17 10:26:53 PDT

Size: 2.00 KB

patch

obsolete

>From 978cddff12c7c0df572112ab98e9f1fa65e3f158 Mon Sep 17 00:00:00 2001
>From: Daniel Bates <dabates@apple.com>
>Date: Mon, 17 Jun 2019 10:24:46 -0700
>Subject: [PATCH] Just for laughs
>
>---
> .../UIProcess/ios/WKContentViewInteraction.mm       | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index 81fa43f3a41..91f625c0e28 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -1223,8 +1223,10 @@ - (void)endEditingAndUpdateFocusAppearanceWithReason:(EndEditingReason)reason
>     if (!_webView._retainingActiveFocusedState) {
>         // We need to complete the editing operation before we blur the element.
>         [self _endEditing];
>-        if ((reason == EndEditingReasonAccessoryDone && !currentUserInterfaceIdiomIsPad()) || _keyboardDidRequestDismissal)
>+        if ((reason == EndEditingReasonAccessoryDone && !currentUserInterfaceIdiomIsPad()) || _keyboardDidRequestDismissal) {
>             _page->blurFocusedElement();
>+            [self _elementDidBlur];
>+        }
>     }
> 
>     [self _cancelInteraction];
>@@ -5265,12 +5267,13 @@ - (void)_elementDidBlur
>         [self removeFocusedFormControlOverlay];
> #endif
> 
>-    // The custom fixed position rect behavior is affected by -isFocusingElement, so if that changes we need to recompute rects.
>-    if (editableChanged)
>+    if (editableChanged) {
>+        // The custom fixed position rect behavior is affected by -isFocusingElement, so if that changes we need to recompute rects.
>         [_webView _scheduleVisibleContentRectUpdate];
> 
>-    [_webView didEndFormControlInteraction];
>-    _page->setIsShowingInputViewForFocusedElement(false);
>+        [_webView didEndFormControlInteraction];
>+        _page->setIsShowingInputViewForFocusedElement(false);
>+    }
> 
>     if (!_isChangingFocus)
>         _didAccessoryTabInitiateFocus = NO;
>-- 
>2.21.0 (Apple Git-118)
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198922: 372253 | 372262 | 372268 | 372374 | 372386