Attachment 372241 Details for Bug 198914 – Patch

[patch] Patch

bug-198914-20190617065854.patch (text/plain), 2.28 KB, created by Michael Catanzaro on 2019-06-17 04:58:55 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2019-06-17 04:58:55 PDT

Size: 2.28 KB

patch

obsolete

>Subversion Revision: 246362
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index f37f7eb1ff7f58535403aedb4a219b517e224704..cbc579d5fb5c8ac1859e49dfbdd6c6505617fca3 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-06-17  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        Require GCC 7
>+        https://bugs.webkit.org/show_bug.cgi?id=198914
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove now-stale GCC version check.
>+
>+        * wtf/Compiler.h:
>+
> 2019-06-10  Simon Fraser  <simon.fraser@apple.com>
> 
>         Add logging for UI-side compositing hit-testing
>diff --git a/Source/WTF/wtf/Compiler.h b/Source/WTF/wtf/Compiler.h
>index 1f6c90b65a2982f15a87c3eee4c9d88ef959b67a..685d516322d786ada7f7660e36ef842588261ae9 100644
>--- a/Source/WTF/wtf/Compiler.h
>+++ b/Source/WTF/wtf/Compiler.h
>@@ -205,10 +205,8 @@
> #elif !defined(FALLTHROUGH) && !defined(__cplusplus)
> 
> #if COMPILER(GCC)
>-#if GCC_VERSION_AT_LEAST(7, 0, 0)
> #define FALLTHROUGH __attribute__ ((fallthrough))
> #endif
>-#endif
> 
> #endif // !defined(FALLTHROUGH) && defined(__cplusplus) && defined(__has_cpp_attribute)
> 
>diff --git a/CMakeLists.txt b/CMakeLists.txt
>index 459ea7b839e6e8bccc348446020188df7cbc3d5d..bebbc2765b5c0fcea5dbf93a6f311269978c6482 100644
>--- a/CMakeLists.txt
>+++ b/CMakeLists.txt
>@@ -61,8 +61,8 @@ if (${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang" OR ${CMAKE_CXX_COMPILER_ID} STREQU
> endif ()
> 
> if (${CMAKE_CXX_COMPILER_ID} STREQUAL "GNU")
>-    if (${CMAKE_CXX_COMPILER_VERSION} VERSION_LESS "6.0.0")
>-        message(FATAL_ERROR "GCC 6.0.0 is required to build WebKitGTK+, use a newer GCC version or clang")
>+    if (${CMAKE_CXX_COMPILER_VERSION} VERSION_LESS "7.0.0")
>+        message(FATAL_ERROR "GCC 7 is required to build WebKitGTK, use a newer GCC version or clang")
>     endif ()
> endif ()
> 
>diff --git a/ChangeLog b/ChangeLog
>index 42a2f75d7acda1c73b13c5b804cd90c463172170..35d9e67b5a82e5caf93445d03946241cbe249d2e 100644
>--- a/ChangeLog
>+++ b/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-06-17  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        Require GCC 7
>+        https://bugs.webkit.org/show_bug.cgi?id=198914
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * CMakeLists.txt:
>+
> 2019-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         [GTK] Remove option REDIRECTED_XCOMPOSITE_WINDOW

Flags:

darin: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 198914: 372241 | 372594