Attachment 372217 Details for Bug 198865 – Patch

[patch] Patch

bug-198865-20190615212558.patch (text/plain), 1.33 KB, created by youenn fablet on 2019-06-15 21:25:59 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-06-15 21:25:59 PDT

Size: 1.33 KB

patch

obsolete

>Subversion Revision: 246451
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 7498cd07362249f0ecc4e3c95051e5e06dfbbfb7..a758b7b89e760d06d61f9ab37538810d46641316 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-06-15  Youenn Fablet  <youenn@apple.com>
>+
>+        WebProcessPool::clearWebProcessHasUploads cannot assume its given processIdentifier is valid
>+        https://bugs.webkit.org/show_bug.cgi?id=198865
>+
>+        Unreviewed.
>+
>+        * UIProcess/WebProcessPool.cpp:
>+        (WebKit::WebProcessPool::clearWebProcessHasUploads):
>+        Remove wrong debug assertion in case of WebProcessProxy destruction.
>+
> 2019-06-15  Youenn Fablet  <youenn@apple.com>
> 
>         WebProcessPool::clearWebProcessHasUploads cannot assume its given processIdentifier is valid
>diff --git a/Source/WebKit/UIProcess/WebProcessPool.cpp b/Source/WebKit/UIProcess/WebProcessPool.cpp
>index f158268b3bb959de918e06734687862b0f79ce91..837caf7cc80e8eaf48a3dfe5b2cf52f689131868 100644
>--- a/Source/WebKit/UIProcess/WebProcessPool.cpp
>+++ b/Source/WebKit/UIProcess/WebProcessPool.cpp
>@@ -2559,7 +2559,6 @@ void WebProcessPool::clearWebProcessHasUploads(ProcessIdentifier processID)
> {
>     ASSERT(processID);
>     auto result = m_processesWithUploads.take(processID);
>-    ASSERT(result);
>     if (!result)
>         return;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198865: 372139 | 372148 | 372217