Attachment 372216 Details for Bug 198902 – Patch

[patch] Patch

bug-198902-20190615211154.patch (text/plain), 1.79 KB, created by youenn fablet on 2019-06-15 21:11:54 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-06-15 21:11:54 PDT

Size: 1.79 KB

patch

obsolete

>Subversion Revision: 246451
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index c65ca91951dba4e9045ce6c66d416bcf2bd9f134..17ba94386b992395b41c8721552060bc6b929d73 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-06-15  Youenn Fablet  <youenn@apple.com>
>+
>+        WebPageProxy should use the right path for sandbox extension
>+        https://bugs.webkit.org/show_bug.cgi?id=198902
>+        rdar://problem/50772810
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        When doing process swapping, a file based loading may end up being loaded through loadRequestWithNavigationShared.
>+        In that case, the sandbox extension was using '/' as path which might not be readable by the UIProcess.
>+        Instead, use the file system path of the URL.
>+
>+        * UIProcess/WebPageProxy.cpp:
>+        (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
>+
> 2019-06-14  Youenn Fablet  <youenn@apple.com>
> 
>         WebResourceLoadStatisticsStore should not use its network session if invalidated
>diff --git a/Source/WebKit/UIProcess/WebPageProxy.cpp b/Source/WebKit/UIProcess/WebPageProxy.cpp
>index 303e74fb73af8abfafda0a4b3b0722ab3c771199..313696b0695a21a84e0002006fbf64cdb4f0ae89 100644
>--- a/Source/WebKit/UIProcess/WebPageProxy.cpp
>+++ b/Source/WebKit/UIProcess/WebPageProxy.cpp
>@@ -1055,7 +1055,7 @@ bool WebPageProxy::maybeInitializeSandboxExtensionHandle(WebProcessProxy& proces
>     // Inspector resources are in a directory with assumed access.
>     ASSERT_WITH_SECURITY_IMPLICATION(!WebKit::isInspectorPage(*this));
> 
>-    SandboxExtension::createHandle("/", SandboxExtension::Type::ReadOnly, sandboxExtensionHandle);
>+    SandboxExtension::createHandle(url.fileSystemPath(), SandboxExtension::Type::ReadOnly, sandboxExtensionHandle);
>     return true;
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198902: 372216 | 372218 | 372219 | 372275 | 372340 | 372350 | 372513 | 372556 | 372574