Attachment 372209 Details for Bug 198897 – Patch

[patch] Patch

bug-198897-20190615191520.patch (text/plain), 2.22 KB, created by Devin Rousso on 2019-06-15 19:15:21 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-06-15 19:15:21 PDT

Size: 2.22 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 926b90cc67776b20e5fc5f9541c3d14024093263..2ae38a2b0970afa2440d5d3a6a1da1545a706c1d 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-06-15  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Sources: searching doesn't use the case sensitive or regex global settings
>+        https://bugs.webkit.org/show_bug.cgi?id=198897
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/SourceCodeTextEditor.js:
>+        (WI.SourceCodeTextEditor.prototype.customPerformSearch):
>+
> 2019-06-13  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: REGRESSION(r246178): extra spaces added in at-rules when formatting CSS
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js b/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js
>index be8ca15e5a6c7de28cd7dcab2d2096d7e4441bed..8170b50a6e3509a6ffd76e924d91cfd92d657162 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js
>@@ -253,10 +253,13 @@ WI.SourceCodeTextEditor = class SourceCodeTextEditor extends WI.TextEditor
>         if (this._sourceCode instanceof WI.SourceMapResource)
>             return false;
> 
>+        let caseSensitive = WI.SearchUtilities.defaultSettings.caseSensitive.value;
>+        let isRegex = WI.SearchUtilities.defaultSettings.regularExpression.value;
>+
>         if (this._sourceCode instanceof WI.Resource)
>-            PageAgent.searchInResource(this._sourceCode.parentFrame.id, this._sourceCode.url, query, false, false, searchResultCallback.bind(this));
>+            PageAgent.searchInResource(this._sourceCode.parentFrame.id, this._sourceCode.url, query, caseSensitive, isRegex, searchResultCallback.bind(this));
>         else if (this._sourceCode instanceof WI.Script)
>-            this._sourceCode.target.DebuggerAgent.searchInContent(this._sourceCode.id, query, false, false, searchResultCallback.bind(this));
>+            this._sourceCode.target.DebuggerAgent.searchInContent(this._sourceCode.id, query, caseSensitive, isRegex, searchResultCallback.bind(this));
>         return true;
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198897: 372209