Attachment 372177 Details for Bug 198596 – Patch

[patch] Patch

bug-198596-20190615024917.patch (text/plain), 1.72 KB, created by Jamal Nasser on 2019-06-14 23:49:18 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jamal Nasser

Created: 2019-06-14 23:49:18 PDT

Size: 1.72 KB

patch

obsolete

>Index: Source/WebInspectorUI/ChangeLog
>===================================================================
>--- Source/WebInspectorUI/ChangeLog	(revision 246456)
>+++ Source/WebInspectorUI/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2019-06-14  Jamal Nasser  <jamaln@mail.com>
>+
>+        Web Inspector: Go To Line dialog is white when in Dark Mode
>+        https://bugs.webkit.org/show_bug.cgi?id=198596
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/GoToLineDialog.css:
>+        (@media (prefers-color-scheme: dark)):
>+        (.go-to-line-dialog):
>+        (.go-to-line-dialog > div > input):
>+        (.go-to-line-dialog > div > input::placeholder):
>+        (.go-to-line-dialog > div::before):
>+
> 2019-06-13  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: REGRESSION(r246178): extra spaces added in at-rules when formatting CSS
>Index: Source/WebInspectorUI/UserInterface/Views/GoToLineDialog.css
>===================================================================
>--- Source/WebInspectorUI/UserInterface/Views/GoToLineDialog.css	(revision 246103)
>+++ Source/WebInspectorUI/UserInterface/Views/GoToLineDialog.css	(working copy)
>@@ -93,3 +93,22 @@
> .go-to-line-dialog.non-empty > div > img {
>     display: block;
> }
>+
>+@media (prefers-color-scheme: dark) {
>+    .go-to-line-dialog {
>+        background-color: var(--overlay-background);
>+        border-color: hsla(0, 0%, var(--foreground-lightness), 0.2);
>+    }
>+
>+    .go-to-line-dialog > div > input {
>+        color: var(--text-color-active);
>+    }
>+
>+    .go-to-line-dialog > div > input::placeholder {
>+        color: var(--text-color-secondary);
>+    }
>+    
>+    .go-to-line-dialog > div::before {
>+        filter: invert();
>+    }
>+}
>\ No newline at end of file

Actions: View | Formatted Diff | Diff

Attachments on bug 198596: 371615 | 371617 | 372177