WebKit Bugzilla
Attachment 372145 Details for
Bug 198871
: [Cocoa] NSFileWrapper associated with _WKAttachment is leaking
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
[PATCH] Proposed Fix
attachment-1.patch (text/plain), 1.14 KB, created by
Joseph Pecoraro
on 2019-06-14 15:00:46 PDT
(
hide
)
Description:
[PATCH] Proposed Fix
Filename:
MIME Type:
Creator:
Joseph Pecoraro
Created:
2019-06-14 15:00:46 PDT
Size:
1.14 KB
patch
obsolete
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index be102fd6f52..bdb2aa407fc 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,15 @@ >+2019-06-14 Joseph Pecoraro <pecoraro@apple.com> >+ >+ [Cocoa] NSFileWrapper associated with _WKAttachment >+ https://bugs.webkit.org/show_bug.cgi?id=198871 >+ <rdar://problem/51760625> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * UIProcess/API/Cocoa/_WKAttachment.mm: >+ (-[_WKAttachment dealloc]): >+ Ensure we destruct the API::Object associated with this so RetainPtrs can release. >+ > 2019-06-13 Megan Gardner <megan_gardner@apple.com> > > Fix selection hang in Mail >diff --git a/Source/WebKit/UIProcess/API/Cocoa/_WKAttachment.mm b/Source/WebKit/UIProcess/API/Cocoa/_WKAttachment.mm >index 4549605576a..00d964fcc17 100644 >--- a/Source/WebKit/UIProcess/API/Cocoa/_WKAttachment.mm >+++ b/Source/WebKit/UIProcess/API/Cocoa/_WKAttachment.mm >@@ -102,6 +102,13 @@ @end > > @implementation _WKAttachment > >+- (void)dealloc >+{ >+ _attachment->~Attachment(); >+ >+ [super dealloc]; >+} >+ > - (API::Object&)_apiObject > { > return *_attachment;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 198871
: 372145