Attachment 372094 Details for Bug 198846 – Patch

[patch] Patch

bug-198846-20190614045313.patch (text/plain), 1.35 KB, created by Alexey Shvayka on 2019-06-13 18:53:14 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alexey Shvayka

Created: 2019-06-13 18:53:14 PDT

Size: 1.35 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 246417)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2019-06-13  Alexey Shvayka  <shvaikalesh@gmail.com>
>+
>+        Remove extra check in RegExp @matchSlow
>+        https://bugs.webkit.org/show_bug.cgi?id=198846
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Type of RegExp `exec` result is already asserted in @regExpExec.
>+
>+        * builtins/RegExpPrototype.js:
>+        (globalPrivate.matchSlow): Remove isObject check.
>+
> 2019-06-13  Yusuke Suzuki  <ysuzuki@apple.com>
> 
>         Yarr bytecode compilation failure should be gracefully handled
>Index: Source/JavaScriptCore/builtins/RegExpPrototype.js
>===================================================================
>--- Source/JavaScriptCore/builtins/RegExpPrototype.js	(revision 246067)
>+++ Source/JavaScriptCore/builtins/RegExpPrototype.js	(working copy)
>@@ -114,9 +114,6 @@ function matchSlow(regexp, str)
>         if (resultList.length > maximumReasonableMatchSize)
>             @throwOutOfMemoryError();
> 
>-        if (!@isObject(result))
>-            @throwTypeError("RegExp.prototype.@@match call to RegExp.exec didn't return null or an object");
>-
>         let resultString = @toString(result[0]);
> 
>         if (!resultString.length)

Actions: View | Formatted Diff | Diff

Attachments on bug 198846: 372094