Attachment 372084 Details for Bug 198845 – Patch

[patch] Patch

bug-198845-20190613165754.patch (text/plain), 1.36 KB, created by Megan Gardner on 2019-06-13 16:57:55 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Megan Gardner

Created: 2019-06-13 16:57:55 PDT

Size: 1.36 KB

patch

obsolete

>Subversion Revision: 246417
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index b1068f7ee4217268165a048419577308adf51c8c..e67e4c1a2edb0e7e5307c9136347e5b593abf2e6 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-13  Megan Gardner  <megan_gardner@apple.com>
>+
>+        Fix selection hang in Mail
>+        https://bugs.webkit.org/show_bug.cgi?id=198845
>+        <rdar://problem/51538344>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        SelectionDidChange requires a selectionWillChange in order to keep things in line.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView _selectionChanged]):
>+
> 2019-06-13  Tim Horton  <timothy_horton@apple.com>
> 
>         No content shows up for WKWebView while locked even with _canShowWhileLocked is YES
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index ba5a86774d88125bdb70fe49f6381c5c703b518c..62b3ae19877aaa18458baa34d8e4ddcd532aea78 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -5764,6 +5764,7 @@ - (void)_selectionChanged
>     }
> #endif
> 
>+    [self.inputDelegate selectionWillChange:self];
>     [self.inputDelegate selectionDidChange:self];
>     
>     [_webView _didChangeEditorState];

Actions: View | Formatted Diff | Diff

Attachments on bug 198845: 372084 | 372085