Attachment 372065 Details for Bug 198835 – Patch

[patch] Patch

bug-198835-20190613102307.patch (text/plain), 2.27 KB, created by Daniel Bates on 2019-06-13 10:23:08 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2019-06-13 10:23:08 PDT

Size: 2.27 KB

patch

obsolete

>Subversion Revision: 246325
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 74c9db0deb39ac8b46854e8db49be93023cbe97f..a1e7a143a284d862f02649a56120342ac3f56108 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,22 @@
>+2019-06-13  Daniel Bates  <dabates@apple.com>
>+
>+        [iOS] Normalize test result of fast/events/ios/keyboard-event-key-attribute.html to handle possible modifier dispatch
>+        https://bugs.webkit.org/show_bug.cgi?id=198835
>+        <rdar://problem/46082708>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        WebKit now knows how to handle flag change events on iOS and dispatch DOM events just like Mac.
>+        Until USE(UIKIT_KEYBOARD_ADDITIONS) is enabled by default WebKit does not expect to receive
>+        modifier flag changes. But once this compile time flag is enabled it will and the test
>+        fast/events/ios/keyboard-event-key-attribute.html will fail because it types '@' and only
>+        expects to see a single keydown for '@' even though it actually requires two key downs to
>+        generate an '@': Shift, and 2 (on a US keyboard layout). We have a bunch of other tests to
>+        check that modifier key presses generate DOM events. So, let's just normalize the result of
>+        this test to ignore Shift keydowns.
>+
>+        * fast/events/ios/keyboard-event-key-attribute.html:
>+
> 2019-06-13  Daniel Bates  <dabates@apple.com>
> 
>         [iOS] Split up fast/events/ios/key-events-meta-alt-combinations.html and add more tests
>diff --git a/LayoutTests/fast/events/ios/keyboard-event-key-attribute.html b/LayoutTests/fast/events/ios/keyboard-event-key-attribute.html
>index 7c1a2fcff2e333ad5d9ca95e5afc7e1534f9f6a7..58750afe6d58789c3259de69ac2742281f9a9d58 100644
>--- a/LayoutTests/fast/events/ios/keyboard-event-key-attribute.html
>+++ b/LayoutTests/fast/events/ios/keyboard-event-key-attribute.html
>@@ -30,6 +30,9 @@ function getTypingUIScript(x, y)
> var i = 0;
> var testInput = document.getElementById("testInput");
> testInput.onkeydown = function(e) {
>+    // Ignore the Shift key so as to normalize the test results across different iOS versions.
>+    if (e.key == "Shift")
>+        return;
>     event = e;
>     shouldBeEqualToString("event.key", "" + tests[i][0]);
>     shouldBeEqualToString("event.code", "" + tests[i][1]);

Actions: View | Formatted Diff | Diff

Attachments on bug 198835: 372065