Attachment 372058 Details for Bug 198833 – Patch

[patch] Patch

bug-198833-20190613091646.patch (text/plain), 1.78 KB, created by Devin Rousso on 2019-06-13 09:16:49 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-06-13 09:16:49 PDT

Size: 1.78 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index eaecae15bb51b34f2800dc6b54be72133ad7360e..723f1c199ebddbc29930384051f64742b603e2e0 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-06-13  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Settings: sticky header disappears when over scrolling
>+        https://bugs.webkit.org/show_bug.cgi?id=198833
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/SettingsTabContentView.css:
>+        (.content-view.settings .navigation-bar):
>+        (.content-view.settings > .settings-view): Added.
>+        (.content-view.settings): Deleted.
>+
> 2019-06-10  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Timelines: imported recordings do not have JavaScript call trees
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css
>index c23f74e38fd7ae431bf4b8fa98db7ae9e42a27a9..ebfab86f39c49b4a34935834951eb1b06eb8fe09 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css
>@@ -24,15 +24,7 @@
>  * THE POSSIBILITY OF SUCH DAMAGE.
>  */
> 
>-.content-view.settings {
>-    padding-bottom: 6vh;
>-    overflow-y: auto;
>-}
>-
> .content-view.settings .navigation-bar {
>-    position: sticky;
>-    top: 0;
>-    z-index: 1;
>     background-color: white;
> }
> 
>@@ -53,6 +45,12 @@
>     color: var(--selected-background-color)
> }
> 
>+.content-view.settings > .settings-view {
>+    height: 100%;
>+    overflow-y: auto;
>+    padding-bottom: calc(var(--console-prompt-min-height) + 10px);
>+}
>+
> .content-view.settings > .settings-view > .separator {
>     height: 1em;
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 198833: 372058