Attachment 372056 Details for Bug 198832 – patch

[patch] patch

twitch-scrolling.patch (text/plain), 4.92 KB, created by Antti Koivisto on 2019-06-13 08:55:23 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Antti Koivisto

Created: 2019-06-13 08:55:23 PDT

Size: 4.92 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 246403)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,21 @@
>+2019-06-13  Antti Koivisto  <antti@apple.com>
>+
>+        twitch.tv: embedded video hovers down the screen when scrolling on iPad
>+        https://bugs.webkit.org/show_bug.cgi?id=198832
>+        <rdar://problem/51541439>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Test: compositing/scrolling/async-overflow-scrolling/overflow-scroll-paint-order-sibling.html
>+
>+        * rendering/RenderLayer.cpp:
>+        (WebCore::RenderLayer::scrollTo):
>+
>+        Overflow scroll layer may have composited descendants that are its paint order siblings. We need to invalidate
>+        the tree of the paint order parent for compositing update (instead of just the tree of the overflow scroll layer).
>+
>+        This matches what RenderLayer::updateLayerPosition() does.
>+
> 2019-06-13  Takashi Komori  <Takashi.Komori@sony.com>
> 
>         [curl] Remove member objects of CurlRequest not to share by different threads.
>Index: Source/WebCore/rendering/RenderLayer.cpp
>===================================================================
>--- Source/WebCore/rendering/RenderLayer.cpp	(revision 246391)
>+++ Source/WebCore/rendering/RenderLayer.cpp	(working copy)
>@@ -2515,7 +2515,11 @@ void RenderLayer::scrollTo(const ScrollP
>             // when that completes.
>             if (usesCompositedScrolling()) {
>                 setNeedsCompositingGeometryUpdate();
>-                setDescendantsNeedUpdateBackingAndHierarchyTraversal();
>+
>+                // Scroll position can affect the location of a composited descendant (which may be a sibling in z-order),
>+                // so trigger a descendant walk from the paint-order parent.
>+                if (auto* paintParent = paintOrderParent())
>+                    paintParent->setDescendantsNeedUpdateBackingAndHierarchyTraversal();
>             }
> 
>             updateCompositingLayersAfterScroll();
>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 246391)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-06-13  Antti Koivisto  <antti@apple.com>
>+
>+        twitch.tv: embedded video hovers down the screen when scrolling on iPad
>+        https://bugs.webkit.org/show_bug.cgi?id=198832
>+        <rdar://problem/51541439>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * compositing/scrolling/async-overflow-scrolling/overflow-scroll-paint-order-sibling-expected.html: Added.
>+        * compositing/scrolling/async-overflow-scrolling/overflow-scroll-paint-order-sibling.html: Added.
>+
> 2019-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         [cairo][SVG] If clipPath has multiple elements, clip-path doesn't work with transform
>Index: LayoutTests/compositing/scrolling/async-overflow-scrolling/overflow-scroll-paint-order-sibling-expected.html
>===================================================================
>--- LayoutTests/compositing/scrolling/async-overflow-scrolling/overflow-scroll-paint-order-sibling-expected.html	(nonexistent)
>+++ LayoutTests/compositing/scrolling/async-overflow-scrolling/overflow-scroll-paint-order-sibling-expected.html	(working copy)
>@@ -0,0 +1,31 @@
>+<!DOCTYPE html> 
>+<style>
>+.scroll {
>+    overflow:scroll;
>+    width: 500px;
>+    height: 500px;
>+    border: 2px solid yellow;
>+}
>+.content {
>+    overflow:hidden;
>+    width: 500px;
>+    height: 1500px;
>+    border: 10px solid green;
>+}
>+.stuff {
>+    position:relative;
>+    top: 200px;
>+    width: 50px;
>+    height: 50px;
>+    background: red;
>+}
>+</style>
>+<div class="scroll" id="scroller">
>+    <div class="content">
>+        <div class="stuff">
>+        </div>
>+    </div>
>+</div>
>+<script>
>+scroller.scrollTo(0, 100);
>+</script>
>Index: LayoutTests/compositing/scrolling/async-overflow-scrolling/overflow-scroll-paint-order-sibling.html
>===================================================================
>--- LayoutTests/compositing/scrolling/async-overflow-scrolling/overflow-scroll-paint-order-sibling.html	(nonexistent)
>+++ LayoutTests/compositing/scrolling/async-overflow-scrolling/overflow-scroll-paint-order-sibling.html	(working copy)
>@@ -0,0 +1,32 @@
>+<!DOCTYPE html> 
>+<style>
>+.scroll {
>+    overflow:scroll;
>+    width: 500px;
>+    height: 500px;
>+    border: 2px solid yellow;
>+}
>+.content {
>+    overflow:hidden;
>+    width: 500px;
>+    height: 1500px;
>+    border: 10px solid green;
>+}
>+.stuff {
>+    position:relative;
>+    top: 200px;
>+    width: 50px;
>+    height: 50px;
>+    background: red;
>+    will-change:transform;
>+}
>+</style>
>+<div class="scroll" id="scroller">
>+    <div class="content">
>+        <div class="stuff">
>+        </div>
>+    </div>
>+</div>
>+<script>
>+scroller.scrollTo(0, 100);
>+</script>

Actions: View | Formatted Diff | Diff

Attachments on bug 198832: 372056