Attachment 372039 Details for Bug 198820 – Patch

[patch] Patch

bug-198820-20190613183601.patch (text/plain), 1.77 KB, created by Fujii Hironori on 2019-06-13 02:36:03 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2019-06-13 02:36:03 PDT

Size: 1.77 KB

patch

obsolete

>Subversion Revision: 246388
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index e1ab018beccdf46679dbf9426a8698bc512e3a61..34d9049412409cc023f699d44e11e7930046070b 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-06-13  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [WinCairo][WebKitTestRunner] pixel image dump outputs black images
>+        https://bugs.webkit.org/show_bug.cgi?id=198820
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        WebView window paints nothing because it is moved out of the
>+        screen. Send WM_PRINT with memory DC instead of WM_PAINT as well
>+        as DumpRenderTree does.
>+
>+        * WebKitTestRunner/win/PlatformWebViewWin.cpp:
>+        (WTR::PlatformWebView::windowSnapshotImage): Send WM_PRINT instead of BitBlt.
>+
> 2019-06-12  Aakash Jain  <aakash_jain@apple.com>
> 
>         Replace double-quotes with single quotes in loadConfig.py
>diff --git a/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp b/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp
>index 3913dba68555036dc56f2c1b13ae175134175d02..002f5517e08936dbda0845d020c52bca8b9e4ac2 100644
>--- a/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp
>+++ b/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp
>@@ -225,17 +225,8 @@ cairo_surface_t* PlatformWebView::windowSnapshotImage()
>     if (!bitmap)
>         return nullptr;
> 
>-    ::InvalidateRect(m_window, nullptr, true);
>     ::SelectObject(memoryDC.get(), bitmap.get());
>-    ::BitBlt(memoryDC.get(),
>-        0,
>-        0,
>-        width,
>-        height,
>-        windowDC,
>-        0,
>-        0,
>-        SRCCOPY);
>+    ::SendMessage(m_window, WM_PRINT, reinterpret_cast<WPARAM>(memoryDC.get()), PRF_CLIENT | PRF_CHILDREN | PRF_OWNED);
> 
>     BITMAP bitmapTag { };
>     GetObject(bitmap.get(), sizeof(bitmapTag), &bitmapTag);

Flags:

ross.kirsling: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 198820: 372039