WebKit Bugzilla
Attachment 371998 Details for
Bug 198813
: AVKit play button bypasses MediaElementSession playbackPermitted() checks.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-198813-20190612161803.patch (text/plain), 1.71 KB, created by
Jer Noble
on 2019-06-12 16:18:04 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Jer Noble
Created:
2019-06-12 16:18:04 PDT
Size:
1.71 KB
patch
obsolete
>Subversion Revision: 246368 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index edda143ba8986b82224e1a45131f265486e41323..de6db6a589cfa4df6cb3d336bb04cf78df330b57 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,18 @@ >+2019-06-12 Jer Noble <jer.noble@apple.com> >+ >+ AVKit play button bypasses MediaElementSession playbackPermitted() checks. >+ https://bugs.webkit.org/show_bug.cgi?id=198813 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ HTMLMediaElement::togglePlayState() is an internal-only method that doesn't >+ run playbackPermitted() checks. For our imitation AVPlayerController, translate >+ requests to -togglePlayback: into calls to play() and pause() depending on >+ playback state. >+ >+ * platform/ios/WebAVPlayerController.mm: >+ (-[WebAVPlayerController togglePlayback:]): >+ > 2019-06-06 Jer Noble <jer.noble@apple.com> > > REGRESSION(244439): platform/mac/media/encrypted-media/fps-* tests are crashing >diff --git a/Source/WebCore/platform/ios/WebAVPlayerController.mm b/Source/WebCore/platform/ios/WebAVPlayerController.mm >index ab5562d9c3ab23c824fc57986251d3bb1312f57f..d59ba87877ec4c8a8c66c180b1e75cab19d444da 100644 >--- a/Source/WebCore/platform/ios/WebAVPlayerController.mm >+++ b/Source/WebCore/platform/ios/WebAVPlayerController.mm >@@ -126,8 +126,13 @@ - (void)pause:(id)sender > - (void)togglePlayback:(id)sender > { > UNUSED_PARAM(sender); >- if (self.delegate) >- self.delegate->togglePlayState(); >+ if (!self.delegate) >+ return; >+ >+ if (self.delegate->isPlaying()) >+ self.delegate->pause(); >+ else >+ self.delegate->play(); > } > > - (void)togglePlaybackEvenWhenInBackground:(id)sender
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 198813
: 371998