Attachment 371991 Details for Bug 198801 – Patch

[patch] Patch

bug-198801-20190612151232.patch (text/plain), 1.68 KB, created by Devin Rousso on 2019-06-12 15:12:33 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-06-12 15:12:33 PDT

Size: 1.68 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 40af09c66197ec572408367328cd3cbd6a7885a3..1d6a531ef4f065c7b14991ee23e40cc65c4d7c6d 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-06-12  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: artificial context menus don't work when Web Inspector is zoomed
>+        https://bugs.webkit.org/show_bug.cgi?id=198801
>+
>+        Reviewed by Joseph Pecoraro.
>+
>+        * inspector/InspectorFrontendHost.cpp:
>+        (WebCore::InspectorFrontendHost::dispatchEventAsContextMenuEvent):
>+        Use the `absoluteLocation` of the `MouseEvent`, which takes into account zoom and scale.
>+
> 2019-06-12  Antti Koivisto  <antti@apple.com>
> 
>         (Async scrolling) Handle 'position:fixed' inside 'position:sticky' correctly.
>diff --git a/Source/WebCore/inspector/InspectorFrontendHost.cpp b/Source/WebCore/inspector/InspectorFrontendHost.cpp
>index 64d1abaec278b1fe142e21612b16599b8949cb20..71ca44bffd460a0fd2f22fdef9e679b39a1b8757 100644
>--- a/Source/WebCore/inspector/InspectorFrontendHost.cpp
>+++ b/Source/WebCore/inspector/InspectorFrontendHost.cpp
>@@ -426,10 +426,8 @@ void InspectorFrontendHost::dispatchEventAsContextMenuEvent(Event& event)
>         return;
> 
>     auto& mouseEvent = downcast<MouseEvent>(event);
>-    IntPoint mousePoint { mouseEvent.clientX(), mouseEvent.clientY() };
>     auto& frame = *downcast<Node>(mouseEvent.target())->document().frame();
>-
>-    m_frontendPage->contextMenuController().showContextMenuAt(frame, mousePoint);
>+    m_frontendPage->contextMenuController().showContextMenuAt(frame, roundedIntPoint(mouseEvent.absoluteLocation()));
> #else
>     UNUSED_PARAM(event);
> #endif

Actions: View | Formatted Diff | Diff

Attachments on bug 198801: 371985 | 371991