Attachment 371989 Details for Bug 198808 – Patch

[patch] Patch

bug-198808-20190612145106.patch (text/plain), 5.15 KB, created by youenn fablet on 2019-06-12 14:51:07 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-06-12 14:51:07 PDT

Size: 5.15 KB

patch

obsolete

>Subversion Revision: 246347
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 358e8a4675c75a7cb000ec8542cb59a7a7361de8..10485d7a7e3d32e3d693f353b40bded224669fd5 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-06-12  Youenn Fablet  <youenn@apple.com>
>+
>+        Update service worker test and expectation after revision 246363
>+        https://bugs.webkit.org/show_bug.cgi?id=198808
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestExpectations:
>+        Skip timing out test in Debug
>+
> 2019-06-12  Youenn Fablet  <youenn@apple.com>
> 
>         Update WPT service workers test up to 0df7c68
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index d93cc4bc46c73c0fd67a3d4c6b4d0054f0ff5e2d..d9bf6aa0e94981680d8537a48d6fc632b1492fde 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-06-12  Youenn Fablet  <youenn@apple.com>
>+
>+        Update service worker test and expectation after revision 246363
>+        https://bugs.webkit.org/show_bug.cgi?id=198808
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt:
>+        * web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https.html:
>+        Make sure the fetch load finishes so that removing the frame does not cancel the fetch.
>+
> 2019-06-12  Youenn Fablet  <youenn@apple.com>
> 
>         Update WPT service workers test up to 0df7c68
>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index 53e3a6c9ec17fcda64469c0822eeb0d27a0bb840..0cacad5f87bc6b2c55db06605047279c2b024383 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -213,6 +213,7 @@ imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-usin
> imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-without-using-registration.https.html [ Skip ]
> imported/w3c/web-platform-tests/service-workers/service-worker/update-not-allowed.https.html [ Skip ]
> imported/w3c/web-platform-tests/service-workers/service-worker/worker-in-sandboxed-iframe-by-csp-fetch-event.https.html [ Skip ]
>+[ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/ready.https.html [ Skip ]
> 
> # Newly imported service worker tests that are flaky.
> imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect-to-http.https.html [ Pass Failure ]
>@@ -281,7 +282,6 @@ imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-res
> [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-order.https.html [ Slow ]
> [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/getregistrations.https.html [ Slow ]
> [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html [ Slow ]
>-[ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/ready.https.html [ Slow ]
> [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/multiple-update.https.html [ Slow ]
> [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/windowclient-navigate.https.html [ Slow ]
> [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/activation.https.html [ Slow ]
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt
>index e3da13c10d3c388c9059f9cfdd4fc02d84b89402..a78b90a67a85324ab7fac3d56ae0a1e8a5f228d8 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt
>@@ -1,6 +1,3 @@
>-CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: cancelled
>-
>-Harness Error (FAIL), message = cancelled
> 
> PASS global setup 
> PASS respondWith in a task throws InvalidStateError 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https.html b/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https.html
>index ae64fcb9a5445843afb75679d0dafa45a3366677..d9147f85494c21e54d39a4fd7af16efa1a126384 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https.html
>+++ b/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https.html
>@@ -44,10 +44,12 @@ async function do_test(url) {
>   assert_equals(response, 'messageHandlerInitialized');
> 
>   // Start a fetch.
>-  frame.contentWindow.fetch(url);
>+  const fetchPromise = frame.contentWindow.fetch(url);
> 
>   // Receive the test result from the service worker.
>-  return wait_for_message();
>+  const result = wait_for_message();
>+  await fetchPromise.then(()=> {}, () => {});
>+  return result;
> };
> 
> promise_test(async (t) => {

Actions: View | Formatted Diff | Diff

Attachments on bug 198808: 371988 | 371989