Attachment 371985 Details for Bug 198801 – Patch

[patch] Patch

bug-198801-20190612141018.patch (text/plain), 1.56 KB, created by Devin Rousso on 2019-06-12 14:10:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-06-12 14:10:19 PDT

Size: 1.56 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 40af09c66197ec572408367328cd3cbd6a7885a3..c44b4a7fe1d84d075de374ee40ef010dd296b050 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-06-12  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: artificial context menus don't work when Web Inspector is zoomed
>+        https://bugs.webkit.org/show_bug.cgi?id=198801
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * inspector/InspectorFrontendHost.cpp:
>+        (WebCore::InspectorFrontendHost::dispatchEventAsContextMenuEvent):
>+        If the Web Inspector is zoomed, adjust the `clientX`/`clientY` by the zoom factor.
>+
> 2019-06-12  Antti Koivisto  <antti@apple.com>
> 
>         (Async scrolling) Handle 'position:fixed' inside 'position:sticky' correctly.
>diff --git a/Source/WebCore/inspector/InspectorFrontendHost.cpp b/Source/WebCore/inspector/InspectorFrontendHost.cpp
>index 64d1abaec278b1fe142e21612b16599b8949cb20..287a21fbbce8c439769a5017d851e9cc8cd14444 100644
>--- a/Source/WebCore/inspector/InspectorFrontendHost.cpp
>+++ b/Source/WebCore/inspector/InspectorFrontendHost.cpp
>@@ -426,7 +426,10 @@ void InspectorFrontendHost::dispatchEventAsContextMenuEvent(Event& event)
>         return;
> 
>     auto& mouseEvent = downcast<MouseEvent>(event);
>+
>     IntPoint mousePoint { mouseEvent.clientX(), mouseEvent.clientY() };
>+    mousePoint.scale(zoomFactor());
>+
>     auto& frame = *downcast<Node>(mouseEvent.target())->document().frame();
> 
>     m_frontendPage->contextMenuController().showContextMenuAt(frame, mousePoint);

Actions: View | Formatted Diff | Diff

Attachments on bug 198801: 371985 | 371991