WebKit Bugzilla
Attachment 371982 Details for
Bug 198799
: [iOS] Adjust tests platform/ipad/fast/forms/{select-form-run-twice, unfocus-inside-fixed-hittest}.html following r243808
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-198799-20190612130915.patch (text/plain), 2.97 KB, created by
Daniel Bates
on 2019-06-12 13:09:16 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Daniel Bates
Created:
2019-06-12 13:09:16 PDT
Size:
2.97 KB
patch
obsolete
>Subversion Revision: 246325 >diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index ad9bc6f96b8fe281eeda1a3c238bed170d713dd8..143f77a563698dd3b72a49fe7fc6650c160e17b6 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,20 @@ >+2019-06-12 Daniel Bates <dabates@apple.com> >+ >+ [iOS] Adjust tests platform/ipad/fast/forms/{select-form-run-twice, unfocus-inside-fixed-hittest}.html following r243808 >+ https://bugs.webkit.org/show_bug.cgi?id=198799 >+ <rdar://problem/50181023> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Following r243808 we no longer defocus a <select> on iPad when its popover is dismissed as a >+ result of picking a value for it. This is to make the behavior of <select> on iPad like the Mac. >+ However the tests platform/ipad/fast/forms/{select-form-run-twice, unfocus-inside-fixed-hittest}.html >+ depend on the old behavior. So, we need to update them to no longer expect a defocusing of the >+ <select>/the end of form control interaction. >+ >+ * platform/ipad/fast/forms/select-form-run-twice.html: >+ * platform/ipad/fast/forms/unfocus-inside-fixed-hittest.html: >+ > 2019-06-11 Daniel Bates <dabates@apple.com> > > [iOS] Adjust test fast/events/ios/keyup.html to ignore Shift keyups >diff --git a/LayoutTests/platform/ipad/fast/forms/select-form-run-twice.html b/LayoutTests/platform/ipad/fast/forms/select-form-run-twice.html >index 3d854fd99dfdbabab20cf0196e5bb8f0b6c87300..4d6923effad171c18a5faf6519d4b3e64872f347 100644 >--- a/LayoutTests/platform/ipad/fast/forms/select-form-run-twice.html >+++ b/LayoutTests/platform/ipad/fast/forms/select-form-run-twice.html >@@ -53,10 +53,7 @@ > (function() { > uiController.didStartFormControlInteractionCallback = function() { > uiController.selectFormAccessoryPickerRow(${row}); >- }; >- >- uiController.didEndFormControlInteractionCallback = function() { >- uiController.uiScriptComplete(); >+ uiController.uiScriptComplete() > }; > > uiController.singleTapAtPoint(${x}, ${y}, function() { >diff --git a/LayoutTests/platform/ipad/fast/forms/unfocus-inside-fixed-hittest.html b/LayoutTests/platform/ipad/fast/forms/unfocus-inside-fixed-hittest.html >index bbc8e33f1ba2e2b3887c04a2103ebe1eb068231f..f9beb24e26d6af076c2b6257b848b0c061c262b3 100644 >--- a/LayoutTests/platform/ipad/fast/forms/unfocus-inside-fixed-hittest.html >+++ b/LayoutTests/platform/ipad/fast/forms/unfocus-inside-fixed-hittest.html >@@ -53,9 +53,6 @@ > (function() { > uiController.didStartFormControlInteractionCallback = function() { > uiController.selectFormAccessoryPickerRow(5); >- }; >- >- uiController.didEndFormControlInteractionCallback = function() { > uiController.uiScriptComplete(); > }; >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 198799
:
371982
|
371996