Attachment 371966 Details for Bug 198792 – Patch

[patch] Patch

bug-198792-20190612121445.patch (text/plain), 3.80 KB, created by Aakash Jain on 2019-06-12 09:14:46 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-06-12 09:14:46 PDT

Size: 3.80 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 246353)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2019-06-12  Aakash Jain  <aakash_jain@apple.com>
>+
>+        Replace double-quotes with single quotes in loadConfig.py
>+        https://bugs.webkit.org/show_bug.cgi?id=198792
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/loadConfig.py:
>+        * BuildSlaveSupport/ews-build/steps_unittest.py:
>+
> 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         [WPE][GTK] Deprecate WebSQL APIs
>Index: Tools/BuildSlaveSupport/ews-build/loadConfig.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/loadConfig.py	(revision 246353)
>+++ Tools/BuildSlaveSupport/ews-build/loadConfig.py	(working copy)
>@@ -58,17 +58,17 @@ def loadBuilderConfig(c, is_test_mode_en
>     for builder in config['builders']:
>         builder['tags'] = getTagsForBuilder(builder)
>         factory = globals()[builder['factory']]
>-        builder['description'] = builder.pop("shortname")
>+        builder['description'] = builder.pop('shortname')
>         factorykwargs = {}
>-        for key in ["platform", "configuration", "architectures", "triggers", "additionalArguments"]:
>+        for key in ['platform', 'configuration', 'architectures', 'triggers', 'additionalArguments']:
>             value = builder.pop(key, None)
>             if value:
>                 factorykwargs[key] = value
> 
>-        builder["factory"] = factory(**factorykwargs)
>+        builder['factory'] = factory(**factorykwargs)
> 
>         if use_localhost_worker:
>-            builder['workernames'].append("local-worker")
>+            builder['workernames'].append('local-worker')
> 
>         c['builders'].append(builder)
> 
>Index: Tools/BuildSlaveSupport/ews-build/steps_unittest.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(revision 246353)
>+++ Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(working copy)
>@@ -477,7 +477,7 @@ class TestCompileWebKit(BuildStepMixinAd
>         self.setProperty('configuration', 'release')
>         self.expectRemoteCommands(
>             ExpectShell(workdir='wkdir',
>-                        command=["perl", "Tools/Scripts/build-webkit", '--release'],
>+                        command=['perl', 'Tools/Scripts/build-webkit', '--release'],
>                         )
>             + 0,
>         )
>@@ -490,7 +490,7 @@ class TestCompileWebKit(BuildStepMixinAd
>         self.setProperty('configuration', 'debug')
>         self.expectRemoteCommands(
>             ExpectShell(workdir='wkdir',
>-                        command=["perl", "Tools/Scripts/build-webkit", '--debug'],
>+                        command=['perl', 'Tools/Scripts/build-webkit', '--debug'],
>                         )
>             + ExpectShell.log('stdio', stdout='1 error generated.')
>             + 2,
>@@ -559,7 +559,7 @@ class TestCompileJSCOnly(BuildStepMixinA
>         self.setProperty('configuration', 'release')
>         self.expectRemoteCommands(
>             ExpectShell(workdir='wkdir',
>-                        command=["perl", "Tools/Scripts/build-jsc", '--release'],
>+                        command=['perl', 'Tools/Scripts/build-jsc', '--release'],
>                         )
>             + 0,
>         )
>@@ -572,7 +572,7 @@ class TestCompileJSCOnly(BuildStepMixinA
>         self.setProperty('configuration', 'debug')
>         self.expectRemoteCommands(
>             ExpectShell(workdir='wkdir',
>-                        command=["perl", "Tools/Scripts/build-jsc", '--debug'],
>+                        command=['perl', 'Tools/Scripts/build-jsc', '--debug'],
>                         )
>             + ExpectShell.log('stdio', stdout='1 error generated.')
>             + 2,

Actions: View | Formatted Diff | Diff

Attachments on bug 198792: 371966