Attachment 371957 Details for Bug 198789 – Patch

[patch] Patch

bug-198789-20190612082702.patch (text/plain), 1.52 KB, created by Wenson Hsieh on 2019-06-12 08:27:03 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2019-06-12 08:27:03 PDT

Size: 1.52 KB

patch

obsolete

>Subversion Revision: 246278
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 98c6ebab6b5446f5eafc3aee3924902c180986d7..40dc4bf5eea08cf9f500931d0800fa42573e1c43 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        Many layout tests are failing on iPad simulator due to unexpected viewport dimensions
>+        https://bugs.webkit.org/show_bug.cgi?id=198789
>+        <rdar://problem/51595519>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Prevent the shrink-to-fit-content timer from activating on layout tests that use the testing viewport
>+        configuration.
>+
>+        * WebProcess/WebPage/ios/WebPageIOS.mm:
>+        (WebKit::WebPage::immediatelyShrinkToFitContent):
>+
> 2019-06-10  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [iOS] fast/xsl tests are flaky when run after certain viewport shrink-to-fit tests
>diff --git a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>index 8ae3025b64921c05557415c917057a7b8cf98e1a..87d30bfc3d55c2be736b2fa196388d368c1c8449 100644
>--- a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>+++ b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>@@ -3239,6 +3239,9 @@ bool WebPage::immediatelyShrinkToFitContent()
>     if (!m_page->settings().allowViewportShrinkToFitContent())
>         return false;
> 
>+    if (m_useTestingViewportConfiguration)
>+        return false;
>+
>     if (!shouldIgnoreMetaViewport())
>         return false;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198789: 371957