WebKit Bugzilla
Attachment 371947 Details for
Bug 198785
: [GTK] gtk_misc_set_alignment is deprecated since GTK 3.14
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-198785-20190612151640.patch (text/plain), 1.65 KB, created by
Ludovico de Nittis
on 2019-06-12 06:16:42 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Ludovico de Nittis
Created:
2019-06-12 06:16:42 PDT
Size:
1.65 KB
patch
obsolete
>Subversion Revision: 246349 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 898da324a131510884bc00b5abc847d17e4d7838..ddd8a13fd7dc5b72d217b3966008e81b6105c680 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,15 @@ >+2019-06-12 Ludovico de Nittis <ludovico.denittis@collabora.com> >+ >+ [GTK] gtk_misc_set_alignment is deprecated since GTK 3.14 >+ https://bugs.webkit.org/show_bug.cgi?id=198785 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Replace the deprecated gtk_misc_set_alignment with halign and valign. >+ >+ * UIProcess/API/gtk/WebKitAuthenticationDialog.cpp: >+ (createLabelWithLineWrap): >+ > 2019-06-11 Wenson Hsieh <wenson_hsieh@apple.com> > > [iOS] Idempotent text autosizing needs to react properly to viewport changes >diff --git a/Source/WebKit/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp b/Source/WebKit/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp >index c734d8fec12ea0f02d9a50fc3a264fbe830e580e..1674ee141fafde79a78bdffe9561bc801cddcd78 100644 >--- a/Source/WebKit/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp >+++ b/Source/WebKit/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp >@@ -75,7 +75,8 @@ static void authenticationCancelled(WebKitAuthenticationRequest*, WebKitAuthenti > static GtkWidget* createLabelWithLineWrap(const char* text) > { > GtkWidget* label = gtk_label_new(text); >- gtk_misc_set_alignment(GTK_MISC(label), 0, 0.5); >+ gtk_widget_set_halign(label, GTK_ALIGN_START); >+ gtk_widget_set_valign(label, GTK_ALIGN_CENTER); > gtk_label_set_line_wrap(GTK_LABEL(label), TRUE); > gtk_label_set_max_width_chars(GTK_LABEL(label), 40); > return label;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 198785
: 371947