Attachment 371895 Details for Bug 198772 – Patch

[patch] Patch

bug-198772-20190611163847.patch (text/plain), 1.51 KB, created by Timothy Hatcher on 2019-06-11 16:38:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Timothy Hatcher

Created: 2019-06-11 16:38:48 PDT

Size: 1.51 KB

patch

obsolete

>Subversion Revision: 246334
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index cadb9675658769f77bfae7c82b2afc2fbfabf664..32e59ea6872b3b2594df0e9a4be8e39ea9ff9f8b 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-06-11  Timothy Hatcher  <timothy@apple.com>
>+
>+        Scrollbar can show as white on white in dark mode on iOS.
>+        https://bugs.webkit.org/show_bug.cgi?id=198772
>+        rdar://problem/51516743
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/API/Cocoa/WKWebView.mm:
>+        (-[WKWebView _updateScrollViewBackground]): Use UIScrollViewIndicatorStyleBlack instead
>+        of UIScrollViewIndicatorStyleDefault to prevent getting a white scrollbar in dark mode.
>+
> 2019-06-11  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         Unreviewed build warning fixes
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm b/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>index a1beb77b0ec1fd680e8c3824feb83187359a0a4a..3b0fe3b427a288bf9c044be85b360edebd99a034 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>+++ b/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>@@ -1736,7 +1736,7 @@ - (void)_updateScrollViewBackground
>     if (lightness <= .5 && color.isVisible())
>         [_scrollView setIndicatorStyle:UIScrollViewIndicatorStyleWhite];
>     else
>-        [_scrollView setIndicatorStyle:UIScrollViewIndicatorStyleDefault];
>+        [_scrollView setIndicatorStyle:UIScrollViewIndicatorStyleBlack];
> }
> 
> - (void)_videoControlsManagerDidChange

Actions: View | Formatted Diff | Diff

Attachments on bug 198772: 371895