Attachment 371894 Details for Bug 198773 – ROLLOUT of r246320

[patch] ROLLOUT of r246320

bug-198773-20190611163729.patch (text/plain), 7.94 KB, created by WebKit Commit Bot on 2019-06-11 16:37:29 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: WebKit Commit Bot

Created: 2019-06-11 16:37:29 PDT

Size: 7.94 KB

patch

obsolete

>Subversion Revision: 246339
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 8f84085694848dcaa809a23c98a8475f5fc33f02..30759fa42ca5181bfef180f3fe5f181d4f4c8d39 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-06-11  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r246320.
>+        https://bugs.webkit.org/show_bug.cgi?id=198773
>+
>+        New test is failing, and commit is causing another test to
>+        fail. (Requested by ShawnRoberts on #webkit).
>+
>+        Reverted changeset:
>+
>+        "Web Inspector: AXI: Audit: image label test is throwing
>+        spurious errors on elements with existing alt attr, but no
>+        value: <img alt>"
>+        https://bugs.webkit.org/show_bug.cgi?id=194754
>+        https://trac.webkit.org/changeset/246320
>+
> 2019-06-11  Devin Rousso  <drousso@apple.com>
> 
>         Sort the computed styles list
>diff --git a/Source/WebCore/accessibility/AccessibilityObject.cpp b/Source/WebCore/accessibility/AccessibilityObject.cpp
>index 541accea899b726e636d7c52a50320cd19dcdd7c..56cb15bbe8af159274a417449515d24c32e00f15 100644
>--- a/Source/WebCore/accessibility/AccessibilityObject.cpp
>+++ b/Source/WebCore/accessibility/AccessibilityObject.cpp
>@@ -2493,9 +2493,6 @@ String AccessibilityObject::computedRoleString() const
>     // FIXME: Need a few special cases that aren't in the RoleMap: option, etc. http://webkit.org/b/128296
>     AccessibilityRole role = roleValue();
> 
>-    if (accessibilityIsIgnored())
>-        return reverseAriaRoleMap().get(static_cast<int>(AccessibilityRole::Presentational));
>-
>     // We do not compute a role string for generic block elements with user-agent assigned roles.
>     if (role == AccessibilityRole::Group || role == AccessibilityRole::TextGroup)
>         return "";
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index cd695a6901cebfc4414e348c4d6ab7e07870a990..2bdb40660a5b90eef746a752cf35a6f291edbc04 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-06-11  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r246320.
>+        https://bugs.webkit.org/show_bug.cgi?id=198773
>+
>+        New test is failing, and commit is causing another test to
>+        fail. (Requested by ShawnRoberts on #webkit).
>+
>+        Reverted changeset:
>+
>+        "Web Inspector: AXI: Audit: image label test is throwing
>+        spurious errors on elements with existing alt attr, but no
>+        value: <img alt>"
>+        https://bugs.webkit.org/show_bug.cgi?id=194754
>+        https://trac.webkit.org/changeset/246320
>+
> 2019-06-11  Devin Rousso  <drousso@apple.com>
> 
>         Sort the computed styles list
>diff --git a/LayoutTests/accessibility/img-alt-attribute-empty-string-expected.txt b/LayoutTests/accessibility/img-alt-attribute-empty-string-expected.txt
>deleted file mode 100644
>index 29d007461d1d55198472d854f9094d16d560326f..0000000000000000000000000000000000000000
>--- a/LayoutTests/accessibility/img-alt-attribute-empty-string-expected.txt
>+++ /dev/null
>@@ -1,15 +0,0 @@
>-
>-
>-
>-This tests that img elements with alt attribute of empty string are ignored.
>-
>-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
>-
>-
>-PASS imagesGroup.childrenCount is 2
>-PASS platformValueForW3CName(imagesGroup.childAtIndex(0)) is "cake"
>-PASS platformValueForW3CName(imagesGroup.childAtIndex(1)) is "more cake"
>-PASS successfullyParsed is true
>-
>-TEST COMPLETE
>-
>diff --git a/LayoutTests/accessibility/img-alt-attribute-empty-string.html b/LayoutTests/accessibility/img-alt-attribute-empty-string.html
>deleted file mode 100644
>index e6915734e8cea46f4c7e6fda9356b920e6481cf8..0000000000000000000000000000000000000000
>--- a/LayoutTests/accessibility/img-alt-attribute-empty-string.html
>+++ /dev/null
>@@ -1,38 +0,0 @@
>-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
>-<html>
>-<head>
>-<script src="../resources/js-test-pre.js"></script>
>-<script src="../resources/accessibility-helper.js"></script>
>-</head>
>-<body id="body">
>-
>-<div tabindex="0" role="group" id="images">
>-    <img alt="cake" src="resources/cake.png"><br>
>-    <img alt="" src="resources/cake.png" class="empty-string"><br>
>-    <img alt="more cake" src="resources/cake.png"><br>
>-</div>
>-
>-<p id="description"></p>
>-<div id="console"></div>
>-
>-<script>
>-
>-    description("This tests that img elements with alt attribute of empty string are ignored.");
>-
>-    if (window.accessibilityController) {
>-
>-        document.getElementById("images").focus();
>-        var imagesGroup = accessibilityController.focusedElement;
>-        // <img alt="" /> should be ignored, so the count should be 2:
>-        shouldBe("imagesGroup.childrenCount", "2"); 
>-        // make sure alt text is being read before and after
>-        shouldBeEqualToString("platformValueForW3CName(imagesGroup.childAtIndex(0))", "cake");
>-        shouldBeEqualToString("platformValueForW3CName(imagesGroup.childAtIndex(1))", "more cake");
>-    }
>-
>-</script>
>-
>-<script src="../resources/js-test-post.js"></script>
>-</body>
>-</html>
>-
>diff --git a/LayoutTests/accessibility/img-alt-attribute-no-value-expected.txt b/LayoutTests/accessibility/img-alt-attribute-no-value-expected.txt
>deleted file mode 100644
>index 392d42a14486c97077a3a3dc410c64219bc484d1..0000000000000000000000000000000000000000
>--- a/LayoutTests/accessibility/img-alt-attribute-no-value-expected.txt
>+++ /dev/null
>@@ -1,16 +0,0 @@
>-
>-
>-
>-
>-This tests that img elements with an alt attribute and no assigned value are ignored.
>-
>-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
>-
>-
>-PASS imagesGroup.childrenCount is 2
>-PASS platformValueForW3CName(imagesGroup.childAtIndex(0)) is "cake0"
>-PASS platformValueForW3CName(imagesGroup.childAtIndex(1)) is "cake3"
>-PASS successfullyParsed is true
>-
>-TEST COMPLETE
>-
>diff --git a/LayoutTests/accessibility/img-alt-attribute-no-value.html b/LayoutTests/accessibility/img-alt-attribute-no-value.html
>deleted file mode 100644
>index 73bd741a83d81af07b96a6247354731d65340158..0000000000000000000000000000000000000000
>--- a/LayoutTests/accessibility/img-alt-attribute-no-value.html
>+++ /dev/null
>@@ -1,44 +0,0 @@
>-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
>-<html>
>-<head>
>-<script src="../resources/js-test-pre.js"></script>
>-<script src="../resources/accessibility-helper.js"></script>
>-</head>
>-<body id="body">
>-
>-<div tabindex="0" role="group" id="images">
>-    <img alt="cake0" src="resources/cake.png"><br>
>-    <img alt class="unassigned-alt cake1" src="resources/cake.png"><br>
>-    <img class="no-alt cake2" src="resources/cake.png"><br>
>-    <img alt="cake3" src="resources/cake.png"><br>
>-</div>
>-
>-<p id="description"></p>
>-<div id="console"></div>
>-
>-<script>
>-
>-description("This tests that img elements with an alt attribute and no assigned value are ignored.");
>-if (window.accessibilityController) {
>-    document.getElementById("images").focus();
>-    var imagesGroup = accessibilityController.focusedElement;
>-    // there are 4 images, but one has an alt attribute that is unassigned so it should be
>-    // ignored. there is a second image without any alt attribute at all. this image should
>-    // not be ignored. accessibilityController fails to recognize it. this has been
>-    // documented in <rdar://problem/51283943>.
>-    // as a result the image count is 2, but it should be 3.
>-    shouldBe("imagesGroup.childrenCount", "2");
>-    // make sure alt text is being read before and after
>-    shouldBeEqualToString("platformValueForW3CName(imagesGroup.childAtIndex(0))", "cake0");
>-    // accessiblityController should see the <img> element w/o alt attribute as an image,
>-    // but it erroneously classifies it as presentation.. so it won't find the image and use the filename as alt text
>-    // shouldBeEqualToString("platformValueForW3CName(imagesGroup.childAtIndex(2))", "cake.png");
>-    shouldBeEqualToString("platformValueForW3CName(imagesGroup.childAtIndex(1))", "cake3");
>-}
>-
>-</script>
>-
>-<script src="../resources/js-test-post.js"></script>
>-</body>
>-</html>
>-

Actions: View | Formatted Diff | Diff

Attachments on bug 198773: 371894