Attachment 371888 Details for Bug 198768 – To land

[patch] To land

bug-198768-20190611160034.patch (text/plain), 2.02 KB, created by Daniel Bates on 2019-06-11 16:00:35 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2019-06-11 16:00:35 PDT

Size: 2.02 KB

patch

obsolete

>Subversion Revision: 246336
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 003bc0fcb64e86fb5d3b947c47dd80e39e85fb14..66fc22b9856ea9ed3b55b7a5cb875e069e6ace7e 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-11  Daniel Bates  <dabates@apple.com>
>+
>+        [iOS] Adjust test fast/events/ios/keyup.html to ignore Shift keyups
>+        https://bugs.webkit.org/show_bug.cgi?id=198768
>+        <rdar://problem/46082743>
>+
>+        Reviewed by Brent Fulgham.
>+
>+        Ignore Shift keyups as in the future they will be emitted. We have existing test coverage for them
>+        currently skipped in OpenSource that will be unskipped in the future once we enable ENABLE(FULL_KEYBOARD_ACCESS).
>+
>+        * fast/events/ios/keyup.html:
>+
> 2019-06-11  Daniel Bates  <dabates@apple.com>
> 
>         Fix up test result following r245161.
>diff --git a/LayoutTests/fast/events/ios/keyup.html b/LayoutTests/fast/events/ios/keyup.html
>index 5f0a9b9a82fd562762fbb7818e3d0a48df373b86..3ae87158cd0bf59963f7ee9404d67c39e7aac84e 100644
>--- a/LayoutTests/fast/events/ios/keyup.html
>+++ b/LayoutTests/fast/events/ios/keyup.html
>@@ -26,10 +26,15 @@ function log(message)
> 
> function logKeyEvent(event)
> {
>-    let pieces = [];
>-    for (let propertyName of ["type", "key", "code", "keyIdentifier", "keyCode", "charCode", "keyCode", "which"])
>-        pieces.push(`${propertyName}: ${event[propertyName]}`);
>-    log(pieces.join(", "));
>+    // Ignore Shift keyups, if they are dispatched, as not all versions of iOS dispatch them.
>+    if (event.key == "Shift")
>+        ++numberOfFiredKeyEventsForTestComplete;
>+    if (event.key !== "Shift") {
>+        let pieces = [];
>+        for (let propertyName of ["type", "key", "code", "keyIdentifier", "keyCode", "charCode", "keyCode", "which"])
>+            pieces.push(`${propertyName}: ${event[propertyName]}`);
>+        log(pieces.join(", "));
>+    }
>     if (++numberOfFiredKeyEvents >= numberOfFiredKeyEventsForTestComplete && window.testRunner)
>         testRunner.notifyDone();
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 198768: 371885 | 371888