Attachment 371818 Details for Bug 198740 – Patch

[patch] Patch

bug-198740-20190610211617.patch (text/plain), 3.54 KB, created by youenn fablet on 2019-06-10 21:16:18 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-06-10 21:16:18 PDT

Size: 3.54 KB

patch

obsolete

>Subversion Revision: 246170
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 4eee4ee7c77358b5d9ee202806d0267a3b07ab6b..cd5041626cc8199b83ad5cb4b41c08b69016d084 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-10  Youenn Fablet  <youenn@apple.com>
>+
>+        MediaStreamAudioSourceNode::setFormat should check for m_sourceSampleRate equality
>+        https://bugs.webkit.org/show_bug.cgi?id=198740
>+        <rdar://problem/47088939>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Covered by tests that are now passing.
>+
>+        * Modules/webaudio/MediaStreamAudioSourceNode.cpp:
>+        (WebCore::MediaStreamAudioSourceNode::setFormat):
>+
> 2019-06-07  Youenn Fablet  <youenn@apple.com>
> 
>         mediaDevices.enumerateDevices() doesn't list the system default audio devices with deviceId as "default"
>diff --git a/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.cpp b/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.cpp
>index aefb33fee8fd818ff52b43ac5abb8289c977f012..8fd073b18b1478a1dd0a347eb0c3dfd7a8984f21 100644
>--- a/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.cpp
>+++ b/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.cpp
>@@ -72,7 +72,7 @@ MediaStreamAudioSourceNode::~MediaStreamAudioSourceNode()
> void MediaStreamAudioSourceNode::setFormat(size_t numberOfChannels, float sourceSampleRate)
> {
>     float sampleRate = this->sampleRate();
>-    if (numberOfChannels == m_sourceNumberOfChannels && sourceSampleRate == sampleRate)
>+    if (numberOfChannels == m_sourceNumberOfChannels && sourceSampleRate == m_sourceSampleRate)
>         return;
> 
>     // The sample-rate must be equal to the context's sample-rate.
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index adba7def91ae53573ef0bf80ad6003c7ce94a20f..3fcda4485f64b0e69b4e54883b43a1123aa4cd8d 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-06-10  Youenn Fablet  <youenn@apple.com>
>+
>+        MediaStreamAudioSourceNode::setFormat should check for m_sourceSampleRate equality
>+        https://bugs.webkit.org/show_bug.cgi?id=198740
>+        <rdar://problem/47088939>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/mac/TestExpectations:
>+
> 2019-06-10  Youenn Fablet  <youenn@apple.com>
> 
>         Update WPT service workers test up to 0df7c68
>diff --git a/LayoutTests/platform/mac/TestExpectations b/LayoutTests/platform/mac/TestExpectations
>index afd983655cb68c8850b0bd8d0cc13327b312615c..ca4a2d7a51bad68a89380c211671cec814d9716e 100644
>--- a/LayoutTests/platform/mac/TestExpectations
>+++ b/LayoutTests/platform/mac/TestExpectations
>@@ -1934,12 +1934,6 @@ webkit.org/b/175678 media/W3C/video/events/event_progress.html [ Pass Failure ]
> [ Mojave+ ] webgl/2.0.0/conformance2/vertex_arrays/vertex-array-object.html [ Failure ]
> 
> # <rdar://problem/47088939>
>-[ Mojave+ ] webrtc/audio-peer-connection-webaudio.html [ Failure ]
>-[ Mojave+ ] webrtc/audio-replace-track.html [ Failure ]
> [ Mojave+ ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html  [ Failure ]
>-[ Mojave+ ] webrtc/peer-connection-remote-audio-mute.html [ Skip ]
>-[ Mojave+ ] webrtc/peer-connection-audio-mute2.html [ Failure ]
>-[ Mojave+ ] webrtc/peer-connection-audio-mute.html [ Skip ]
>-[ Mojave+ ] webrtc/peer-connection-remote-audio-mute2.html [ Pass Failure ]
> [ Mojave+ ] webaudio/realtimeanalyser-fft-scaling.html [ Pass Failure ]
> [ Mojave+ ] webaudio/oscillator-sine.html [ Skip ]
>\ No newline at end of file

Actions: View | Formatted Diff | Diff

Attachments on bug 198740: 371818