Attachment 371772 Details for Bug 198508 – Patch

[patch] Patch

patch.txt (text/plain), 3.56 KB, created by Nikita Vasilyev on 2019-06-10 13:07:31 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2019-06-10 13:07:31 PDT

Size: 3.56 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 788d30a070f..f6e60105765 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,21 @@
>+2019-06-10  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        REGRESSION(r244268): Web Inspector: Styles: navigating from Computed to Styles doesn't work
>+        https://bugs.webkit.org/show_bug.cgi?id=198508
>+        <rdar://problem/51375503>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        It didn't work because the detached sidebar panel tried to access its parent view (this.parentSidebar).
>+
>+        * UserInterface/Views/ComputedStyleDetailsSidebarPanel.js:
>+        (WI.ComputedStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty): Added.
>+        (WI.ComputedStyleDetailsSidebarPanel):
>+        * UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
>+        (WI.GeneralStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty): Deleted.
>+        Move computedStyleDetailsPanelShowProperty to ComputedStyleDetailsSidebarPanel since it's the only
>+        panel where it's needed.
>+
> 2019-05-24  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Overlay: don't show setting for showing rulers/guides during element selection if it's not supported
>diff --git a/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsSidebarPanel.js
>index f53a1690ece..c343006ecea 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsSidebarPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsSidebarPanel.js
>@@ -29,4 +29,17 @@ WI.ComputedStyleDetailsSidebarPanel = class ComputedStyleDetailsSidebarPanel ext
>     {
>         super("style-computed", WI.UIString("Computed"), WI.ComputedStyleDetailsPanel);
>     }
>+
>+    // ComputedStyleDetailsPanel delegate
>+
>+    computedStyleDetailsPanelShowProperty(property)
>+    {
>+        let styleRulesPanel = this.parentSidebar.sidebarPanels.find((panel) => panel instanceof WI.RulesStyleDetailsSidebarPanel);
>+        console.assert(styleRulesPanel, "Styles panel is missing.");
>+        if (!styleRulesPanel)
>+            return;
>+
>+        this.parentSidebar.selectedSidebarPanel = styleRulesPanel;
>+        styleRulesPanel.panel.scrollToSectionAndHighlightProperty(property);
>+    }
> };
>diff --git a/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js
>index a10004512a9..c02a3e3229a 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js
>@@ -67,23 +67,6 @@ WI.GeneralStyleDetailsSidebarPanel = class GeneralStyleDetailsSidebarPanel exten
>         this._panel.markAsNeedsRefresh(this.domNode);
>     }
> 
>-    computedStyleDetailsPanelShowProperty(property)
>-    {
>-        this.parentSidebar.selectedSidebarPanel = "style-rules";
>-
>-        let styleRulesPanel = null;
>-        for (let sidebarPanel of this.parentSidebar.sidebarPanels) {
>-            if (!(sidebarPanel instanceof WI.RulesStyleDetailsSidebarPanel))
>-                continue;
>-
>-            styleRulesPanel = sidebarPanel;
>-            break;
>-        }
>-
>-        console.assert(styleRulesPanel, "Styles panel is missing.");
>-        styleRulesPanel.panel.scrollToSectionAndHighlightProperty(property);
>-    }
>-
>     // StyleDetailsPanel delegate
> 
>     styleDetailsPanelFocusLastPseudoClassCheckbox(styleDetailsPanel)

Actions: View | Formatted Diff | Diff

Attachments on bug 198508: 371687 | 371772