Attachment 371765 Details for Bug 198724 – PATCH

[patch] PATCH

198724.diff (text/plain), 2.50 KB, created by Basuke Suzuki on 2019-06-10 11:32:32 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Basuke Suzuki

Created: 2019-06-10 11:32:32 PDT

Size: 2.50 KB

patch

obsolete

>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index b708a4becd0..9e13dead8fd 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-06-10  Basuke Suzuki  <Basuke.Suzuki@sony.com>
>+
>+        [WinCairo] Remove build warning from RemoteInspector.
>+        https://bugs.webkit.org/show_bug.cgi?id=198724
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        [Upstrean] Remove build warning.
>+
>+        In `RemoteInspectorConnectionClient.h`, an interface was defined with empty implementation.
>+        This method is to be overwritten by sub classes so that parameter name is important.
>+        The subclasses of the class are just two and one has it's own implementation.
>+        Define this method as an abstract method and move default implementation to that subclass.
>+
>+        * inspector/remote/RemoteInspector.h:
>+        * inspector/remote/socket/RemoteInspectorConnectionClient.h:
>+
> 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
> 
>         [JSC] Linker fails when unified sources are not in use
>diff --git a/Source/JavaScriptCore/inspector/remote/RemoteInspector.h b/Source/JavaScriptCore/inspector/remote/RemoteInspector.h
>index 2b9315e82dc..7316ab81505 100644
>--- a/Source/JavaScriptCore/inspector/remote/RemoteInspector.h
>+++ b/Source/JavaScriptCore/inspector/remote/RemoteInspector.h
>@@ -211,6 +211,7 @@ private:
> #endif
> #if USE(INSPECTOR_SOCKET_SERVER)
>     HashMap<String, CallHandler>& dispatchMap() override;
>+    void didAccept(ConnectionID, ConnectionID, Socket::Domain) override { }
>     void didClose(ConnectionID) override;
> 
>     void sendWebInspectorEvent(const String&);
>diff --git a/Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorConnectionClient.h b/Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorConnectionClient.h
>index c6a62962222..b0384f33485 100644
>--- a/Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorConnectionClient.h
>+++ b/Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorConnectionClient.h
>@@ -37,7 +37,7 @@ namespace Inspector {
> class RemoteInspectorConnectionClient : public CanMakeWeakPtr<RemoteInspectorConnectionClient> {
> public:
>     void didReceiveWebInspectorEvent(ConnectionID, Vector<uint8_t>&&);
>-    virtual void didAccept(ConnectionID acceptedID, ConnectionID listenerID, Socket::Domain) { }
>+    virtual void didAccept(ConnectionID acceptedID, ConnectionID listenerID, Socket::Domain) = 0;
>     virtual void didClose(ConnectionID) = 0;
> 
>     struct Event {

Actions: View | Formatted Diff | Diff

Attachments on bug 198724: 371765 | 371780