WebKit Bugzilla
Attachment 371758 Details for
Bug 198723
: webkitpy: xcrun simctl spawn *** launchctl print system output is not utf-8
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-198723-20190610102406.patch (text/plain), 1.54 KB, created by
Jonathan Bedard
on 2019-06-10 10:24:07 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Jonathan Bedard
Created:
2019-06-10 10:24:07 PDT
Size:
1.54 KB
patch
obsolete
>Index: Tools/ChangeLog >=================================================================== >--- Tools/ChangeLog (revision 246266) >+++ Tools/ChangeLog (working copy) >@@ -1,3 +1,13 @@ >+2019-06-10 Jonathan Bedard <jbedard@apple.com> >+ >+ webkitpy: xcrun simctl spawn *** launchctl print system output is not utf-8 >+ https://bugs.webkit.org/show_bug.cgi?id=198723 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Scripts/webkitpy/xcode/simulated_device.py: >+ (SimulatedDevice.is_usable): Do not decode 'print system' output, it's already ASCII. >+ > 2019-06-10 Sihui Liu <sihui_liu@apple.com> > > [WKHTTPCookieStore getAllCookies:] may return duplicate cookies >Index: Tools/Scripts/webkitpy/xcode/simulated_device.py >=================================================================== >--- Tools/Scripts/webkitpy/xcode/simulated_device.py (revision 246265) >+++ Tools/Scripts/webkitpy/xcode/simulated_device.py (working copy) >@@ -534,7 +534,7 @@ class SimulatedDevice(object): > _log.debug('{} has no service to check if the device is usable'.format(self.device_type.software_variant)) > return True > >- for line in self.executive.run_command([SimulatedDeviceManager.xcrun, 'simctl', 'spawn', self.udid, 'launchctl', 'print', 'system']).splitlines(): >+ for line in self.executive.run_command([SimulatedDeviceManager.xcrun, 'simctl', 'spawn', self.udid, 'launchctl', 'print', 'system'], decode_output=False).splitlines(): > if home_screen_service in line: > return True > return False
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 198723
:
371757
| 371758