Attachment 371754 Details for Bug 198722 – Patch for landing

[patch] Patch for landing

bug-198722-20190610193327.patch (text/plain), 8.02 KB, created by Adrian Perez on 2019-06-10 09:33:29 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Adrian Perez

Created: 2019-06-10 09:33:29 PDT

Size: 8.02 KB

patch

obsolete

>Subversion Revision: 246264
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 0aff93f5605e0ca7d66004e91bca6f86f473771f..455e2f854eea7fd6bae71d5a491f796958f81ed1 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,28 @@
>+2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
>+
>+        [JSC] Linker fails when unified sources are not in use
>+        https://bugs.webkit.org/show_bug.cgi?id=198722
>+
>+        Reviewed by Keith Miller.
>+
>+        Added missing inclusions of headers in several files which make use of inline functions.
>+
>+        * b3/B3AtomicValue.cpp:
>+        * b3/B3BlockInsertionSet.cpp:
>+        * b3/B3FenceValue.cpp:
>+        * b3/B3LowerMacrosAfterOptimizations.cpp:
>+        * b3/B3PureCSE.cpp:
>+        * b3/B3StackmapValue.cpp:
>+        * b3/B3SwitchValue.cpp:
>+        * b3/B3UseCounts.cpp:
>+        * b3/B3VariableValue.cpp:
>+        * b3/B3WasmAddressValue.cpp:
>+        * b3/B3WasmBoundsCheckValue.cpp:
>+        * ftl/FTLCompile.cpp:
>+        * wasm/WasmSectionParser.cpp:
>+        * wasm/WasmTable.cpp:
>+        * wasm/WasmValidate.cpp:
>+
> 2019-06-09  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r246150, r246160, and r246166.
>diff --git a/Source/JavaScriptCore/b3/B3AtomicValue.cpp b/Source/JavaScriptCore/b3/B3AtomicValue.cpp
>index ec544eda66e4315f207359e16016a0401870ebe4..4235863c8e3704f22c46d703566866436dc54da6 100644
>--- a/Source/JavaScriptCore/b3/B3AtomicValue.cpp
>+++ b/Source/JavaScriptCore/b3/B3AtomicValue.cpp
>@@ -25,6 +25,7 @@
> 
> #include "config.h"
> #include "B3AtomicValue.h"
>+#include "B3ValueInlines.h"
> 
> #if ENABLE(B3_JIT)
> 
>diff --git a/Source/JavaScriptCore/b3/B3BlockInsertionSet.cpp b/Source/JavaScriptCore/b3/B3BlockInsertionSet.cpp
>index b00b4549cc4f1f0ea47de1ff1998d3a088a6778d..f7fc72fd2681008685f66d6c174c39b534c31811 100644
>--- a/Source/JavaScriptCore/b3/B3BlockInsertionSet.cpp
>+++ b/Source/JavaScriptCore/b3/B3BlockInsertionSet.cpp
>@@ -31,6 +31,7 @@
> #include "B3BasicBlockInlines.h"
> #include "B3InsertionSet.h"
> #include "B3ProcedureInlines.h"
>+#include "B3ValueInlines.h"
> #include <wtf/BubbleSort.h>
> 
> namespace JSC { namespace B3 {
>diff --git a/Source/JavaScriptCore/b3/B3FenceValue.cpp b/Source/JavaScriptCore/b3/B3FenceValue.cpp
>index 386bfdee42189238e42f1d7df49ed76e71f36956..d234c87ff3b8da913de5be511eb36becc2b39b4d 100644
>--- a/Source/JavaScriptCore/b3/B3FenceValue.cpp
>+++ b/Source/JavaScriptCore/b3/B3FenceValue.cpp
>@@ -25,6 +25,7 @@
> 
> #include "config.h"
> #include "B3FenceValue.h"
>+#include "B3ValueInlines.h"
> 
> #if ENABLE(B3_JIT)
> 
>diff --git a/Source/JavaScriptCore/b3/B3LowerMacrosAfterOptimizations.cpp b/Source/JavaScriptCore/b3/B3LowerMacrosAfterOptimizations.cpp
>index fe0a8833d1a65f5893dde955a683e28ec0bf93b7..b2c5bc65e939b218c556c06c05657cfac12efd1d 100644
>--- a/Source/JavaScriptCore/b3/B3LowerMacrosAfterOptimizations.cpp
>+++ b/Source/JavaScriptCore/b3/B3LowerMacrosAfterOptimizations.cpp
>@@ -37,6 +37,7 @@
> #include "B3ConstPtrValue.h"
> #include "B3InsertionSetInlines.h"
> #include "B3PhaseScope.h"
>+#include "B3ValueInlines.h"
> 
> namespace JSC { namespace B3 {
> 
>diff --git a/Source/JavaScriptCore/b3/B3PureCSE.cpp b/Source/JavaScriptCore/b3/B3PureCSE.cpp
>index e4e9ccd3efac4e0bcfd1b1ac09e25b519d4d5809..346d98315efff6a5ac44caaea39e956405bd0e42 100644
>--- a/Source/JavaScriptCore/b3/B3PureCSE.cpp
>+++ b/Source/JavaScriptCore/b3/B3PureCSE.cpp
>@@ -31,6 +31,7 @@
> #include "B3Dominators.h"
> #include "B3PhaseScope.h"
> #include "B3Value.h"
>+#include "B3ValueInlines.h"
> 
> namespace JSC { namespace B3 {
> 
>diff --git a/Source/JavaScriptCore/b3/B3StackmapValue.cpp b/Source/JavaScriptCore/b3/B3StackmapValue.cpp
>index ba317ba3d0c69a38c76dffaefe2d79af80c21d07..15d9dc9e8350ea92487cd3ff58c9b1d1616dae7c 100644
>--- a/Source/JavaScriptCore/b3/B3StackmapValue.cpp
>+++ b/Source/JavaScriptCore/b3/B3StackmapValue.cpp
>@@ -25,6 +25,7 @@
> 
> #include "config.h"
> #include "B3StackmapValue.h"
>+#include "B3ValueInlines.h"
> 
> #if ENABLE(B3_JIT)
> 
>diff --git a/Source/JavaScriptCore/b3/B3SwitchValue.cpp b/Source/JavaScriptCore/b3/B3SwitchValue.cpp
>index 51165bc9b0afca050ec1464ce80b10be92108a17..d24b047d52aab57ebf3d684abe047d1e4079e4a0 100644
>--- a/Source/JavaScriptCore/b3/B3SwitchValue.cpp
>+++ b/Source/JavaScriptCore/b3/B3SwitchValue.cpp
>@@ -29,6 +29,7 @@
> #if ENABLE(B3_JIT)
> 
> #include "B3BasicBlockInlines.h"
>+#include "B3ValueInlines.h"
> #include <wtf/ListDump.h>
> 
> namespace JSC { namespace B3 {
>diff --git a/Source/JavaScriptCore/b3/B3UseCounts.cpp b/Source/JavaScriptCore/b3/B3UseCounts.cpp
>index 70663c80b40be1231b233720367311039229bcfe..cf36113e38a66bee9780616e620d89b4cfc6e6b6 100644
>--- a/Source/JavaScriptCore/b3/B3UseCounts.cpp
>+++ b/Source/JavaScriptCore/b3/B3UseCounts.cpp
>@@ -29,6 +29,7 @@
> #if ENABLE(B3_JIT)
> 
> #include "B3Procedure.h"
>+#include "B3ValueInlines.h"
> 
> namespace JSC { namespace B3 {
> 
>diff --git a/Source/JavaScriptCore/b3/B3VariableValue.cpp b/Source/JavaScriptCore/b3/B3VariableValue.cpp
>index 887c0b6b5ef28d992303e943249aba4e35d5e43c..646f0f76c5aeff00b33693bf2de746f127e1295a 100644
>--- a/Source/JavaScriptCore/b3/B3VariableValue.cpp
>+++ b/Source/JavaScriptCore/b3/B3VariableValue.cpp
>@@ -28,6 +28,7 @@
> 
> #if ENABLE(B3_JIT)
> 
>+#include "B3ValueInlines.h"
> #include "B3Variable.h"
> 
> namespace JSC { namespace B3 {
>diff --git a/Source/JavaScriptCore/b3/B3WasmAddressValue.cpp b/Source/JavaScriptCore/b3/B3WasmAddressValue.cpp
>index ba7c9373300e42174df6e3656cb8699fee5d3b08..26325af0f4c45e112d33c823b1dd993a43ec61bd 100644
>--- a/Source/JavaScriptCore/b3/B3WasmAddressValue.cpp
>+++ b/Source/JavaScriptCore/b3/B3WasmAddressValue.cpp
>@@ -28,6 +28,8 @@
> 
> #if ENABLE(B3_JIT)
> 
>+#include "B3ValueInlines.h"
>+
> namespace JSC { namespace B3 {
> 
> WasmAddressValue::~WasmAddressValue()
>diff --git a/Source/JavaScriptCore/b3/B3WasmBoundsCheckValue.cpp b/Source/JavaScriptCore/b3/B3WasmBoundsCheckValue.cpp
>index 3833ef53723242c9f556e4c638ccf9abe687f4b2..597d0864079b3c3339011bb074490c6364a08f0d 100644
>--- a/Source/JavaScriptCore/b3/B3WasmBoundsCheckValue.cpp
>+++ b/Source/JavaScriptCore/b3/B3WasmBoundsCheckValue.cpp
>@@ -29,6 +29,8 @@
> 
> #if ENABLE(B3_JIT)
> 
>+#include "B3ValueInlines.h"
>+
> namespace JSC { namespace B3 {
> 
> WasmBoundsCheckValue::~WasmBoundsCheckValue()
>diff --git a/Source/JavaScriptCore/ftl/FTLCompile.cpp b/Source/JavaScriptCore/ftl/FTLCompile.cpp
>index c7db7959bec47054b5db7a2c56d4cd2018abe10f..5d04b72f04831d06302304d1eb7e4929d480427f 100644
>--- a/Source/JavaScriptCore/ftl/FTLCompile.cpp
>+++ b/Source/JavaScriptCore/ftl/FTLCompile.cpp
>@@ -34,6 +34,7 @@
> #include "B3ProcedureInlines.h"
> #include "B3StackSlot.h"
> #include "B3Value.h"
>+#include "B3ValueInlines.h"
> #include "CodeBlockWithJITType.h"
> #include "CCallHelpers.h"
> #include "DFGCommon.h"
>diff --git a/Source/JavaScriptCore/wasm/WasmSectionParser.cpp b/Source/JavaScriptCore/wasm/WasmSectionParser.cpp
>index 7e45deea83d6e5c9b66646b9c2194aef779d84fb..30b6f3ced9df5626222627253c24684a3c8b4943 100644
>--- a/Source/JavaScriptCore/wasm/WasmSectionParser.cpp
>+++ b/Source/JavaScriptCore/wasm/WasmSectionParser.cpp
>@@ -30,6 +30,7 @@
> #if ENABLE(WEBASSEMBLY)
> 
> #include "IdentifierInlines.h"
>+#include "JSCJSValueInlines.h"
> #include "WasmMemoryInformation.h"
> #include "WasmNameSectionParser.h"
> #include "WasmOps.h"
>diff --git a/Source/JavaScriptCore/wasm/WasmTable.cpp b/Source/JavaScriptCore/wasm/WasmTable.cpp
>index e77514c83389a204c81d9c0b5187266353bf3074..b3cb0a2546356824740e6b8128c00ce596099acd 100644
>--- a/Source/JavaScriptCore/wasm/WasmTable.cpp
>+++ b/Source/JavaScriptCore/wasm/WasmTable.cpp
>@@ -28,6 +28,7 @@
> 
> #if ENABLE(WEBASSEMBLY)
> 
>+#include "JSCJSValueInlines.h"
> #include <wtf/CheckedArithmetic.h>
> #include <wtf/StdLibExtras.h>
> #include <type_traits>
>diff --git a/Source/JavaScriptCore/wasm/WasmValidate.cpp b/Source/JavaScriptCore/wasm/WasmValidate.cpp
>index 6619dfbfd03e50a335475ca7df352be120651fed..a4b78e458df4598e0ccda61fa94ec919a29afcf4 100644
>--- a/Source/JavaScriptCore/wasm/WasmValidate.cpp
>+++ b/Source/JavaScriptCore/wasm/WasmValidate.cpp
>@@ -28,6 +28,7 @@
> 
> #if ENABLE(WEBASSEMBLY)
> 
>+#include "JSCJSValueInlines.h"
> #include "WasmFunctionParser.h"
> #include <wtf/CommaPrinter.h>
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198722: 371752 | 371754 | 372452