Attachment 371745 Details for Bug 198382 – Patch

[patch] Patch

bug-198382-20190610111949.patch (text/plain), 1.82 KB, created by Ali Juma on 2019-06-10 08:19:50 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ali Juma

Created: 2019-06-10 08:19:50 PDT

Size: 1.82 KB

patch

obsolete

>Subversion Revision: 246256
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index fb5b50dea19d1d58f201b1c632e9e03b1cc9432c..ba40e99f24dbb12b0da3ee2ab0d2d853e58c00e6 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-06-10  Ali Juma  <ajuma@chromium.org>
>+
>+        REGRESSION (r245396): Page load time performance regression
>+        https://bugs.webkit.org/show_bug.cgi?id=198382
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use a delay of 2000ms instead of 500ms when scheduling rendering updates
>+        for IntersectionObserver targets added during page load. This is a
>+        speculative fix for a page load time regression caused by r245396 and
>+        still not fixed after r245958.
>+
>+        * dom/Document.cpp:
>+        (WebCore::Document::scheduleTimedRenderingUpdate):
>+
> 2019-06-09  Rob Buis  <rbuis@igalia.com>
> 
>         Add wildcard to Access-Control-Allow-Methods and Access-Control-Allow-Headers
>diff --git a/Source/WebCore/dom/Document.cpp b/Source/WebCore/dom/Document.cpp
>index 65193913c58778f68637fbc7720ebce65ce49d72..d3631d5b84bfa1abd3c01b64259d9f70f25a6c16 100644
>--- a/Source/WebCore/dom/Document.cpp
>+++ b/Source/WebCore/dom/Document.cpp
>@@ -353,7 +353,7 @@ private:
> };
> 
> #if ENABLE(INTERSECTION_OBSERVER)
>-static const Seconds intersectionObserversInitialUpdateDelay { 500_ms };
>+static const Seconds intersectionObserversInitialUpdateDelay { 2000_ms };
> #endif
> 
> // DOM Level 2 says (letters added):
>@@ -7294,6 +7294,9 @@ void Document::removeAppearanceDependentPicture(HTMLPictureElement& picture)
> 
> void Document::scheduleTimedRenderingUpdate()
> {
>+#if ENABLE(INTERSECTION_OBSERVER)
>+    m_intersectionObserversInitialUpdateTimer.stop();
>+#endif
>     if (auto page = this->page())
>         page->renderingUpdateScheduler().scheduleTimedRenderingUpdate();
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 198382: 370968 | 370992 | 371610 | 371631 | 371745