Attachment 371740 Details for Bug 198712 – Patch

[patch] Patch

bug-198712-20190610160033.patch (text/plain), 1.73 KB, created by p.stanek on 2019-06-10 07:00:35 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: p.stanek

Created: 2019-06-10 07:00:35 PDT

Size: 1.73 KB

patch

obsolete

>Subversion Revision: 245849
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 900bbe8f18da4eb8056c2e0bac6d50800c85a7c6..f1acf83e7d32ffb4afc045171392cb9625eb3a65 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-10  Pawel Stanek  <p.stanek@metrological.com>
>+
>+        Connection::waitForSyncReply() uses wall time clock for timeout
>+        https://bugs.webkit.org/show_bug.cgi?id=198712
>+        Due to a nature of the system time (it might not be set, jump, be off
>+        by a lot) it is better to use monotonically increasing time which is
>+        exactly what's used in a similar place i.e. Connection::waitForMessage()
>+        
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Platform/IPC/Connection.cpp:
>+        (IPC::Connection::waitForSyncReply):
>+
> 2019-05-28  Fujii Hironori  <Hironori.Fujii@sony.com>
> 
>         [WinCairo] REGRESSION(r245186) Crash in NetworkCache::IOChannel::read in http/tests/IndexedDB some tests
>diff --git a/Source/WebKit/Platform/IPC/Connection.cpp b/Source/WebKit/Platform/IPC/Connection.cpp
>index 361f8619d23c848075bc1074fd67f4ae08cb99b5..e7c6e35bc4be2469d814056fcbd4a50cb4652f21 100644
>--- a/Source/WebKit/Platform/IPC/Connection.cpp
>+++ b/Source/WebKit/Platform/IPC/Connection.cpp
>@@ -583,7 +583,7 @@ std::unique_ptr<Decoder> Connection::sendSyncMessage(uint64_t syncRequestID, std
> std::unique_ptr<Decoder> Connection::waitForSyncReply(uint64_t syncRequestID, Seconds timeout, OptionSet<SendSyncOption> sendSyncOptions)
> {
>     timeout = timeoutRespectingIgnoreTimeoutsForTesting(timeout);
>-    WallTime absoluteTime = WallTime::now() + timeout;
>+    MonotonicTime absoluteTime = MonotonicTime::now() + timeout;
> 
>     willSendSyncMessage(sendSyncOptions);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198712: 371738 | 371740