Attachment 371687 Details for Bug 198508 – Patch

[patch] Patch

patch.txt (text/plain), 1.99 KB, created by Nikita Vasilyev on 2019-06-08 17:31:58 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2019-06-08 17:31:58 PDT

Size: 1.99 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 788d30a070f..871fba14fd5 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-08  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        REGRESSION(r244268): Web Inspector: Styles: navigating from Computed to Styles doesn't work
>+        https://bugs.webkit.org/show_bug.cgi?id=198508
>+        <rdar://problem/51375503>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Save a reference to the parent view (i.e. parentSidebar) before the panel view gets detached.
>+
>+        * UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
>+        (WI.GeneralStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty):
>+
> 2019-05-24  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Overlay: don't show setting for showing rulers/guides during element selection if it's not supported
>diff --git a/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js
>index a10004512a9..ea2d432b099 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js
>@@ -69,10 +69,13 @@ WI.GeneralStyleDetailsSidebarPanel = class GeneralStyleDetailsSidebarPanel exten
> 
>     computedStyleDetailsPanelShowProperty(property)
>     {
>-        this.parentSidebar.selectedSidebarPanel = "style-rules";
>+        let parentSidebar = this.parentSidebar;
>+
>+        // This sets this.parentSidebar to null because ComputedStyleDetailsPanel view gets detached.
>+        parentSidebar.selectedSidebarPanel = "style-rules";
> 
>         let styleRulesPanel = null;
>-        for (let sidebarPanel of this.parentSidebar.sidebarPanels) {
>+        for (let sidebarPanel of parentSidebar.sidebarPanels) {
>             if (!(sidebarPanel instanceof WI.RulesStyleDetailsSidebarPanel))
>                 continue;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198508: 371687 | 371772