Attachment 371668 Details for Bug 198691 – Patch

[patch] Patch

bug-198691-20190609004821.patch (text/plain), 1.35 KB, created by Alexey Shvayka on 2019-06-08 14:48:22 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alexey Shvayka

Created: 2019-06-08 14:48:22 PDT

Size: 1.35 KB

patch

obsolete

>Index: Source/WebInspectorUI/ChangeLog
>===================================================================
>--- Source/WebInspectorUI/ChangeLog	(revision 246234)
>+++ Source/WebInspectorUI/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-06-08  Alexey Shvayka  <shvaikalesh@gmail.com>
>+
>+        Web Inspector: "Copy Path to Property" doesn't work with multiline keys
>+        https://bugs.webkit.org/show_bug.cgi?id=198691
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Correctly escape line terminators to prevent doubleQuotedString from returning malformed strings.
>+
>+        * UserInterface/Base/Utilities.js: Use JSON.stringify.
>+
> 2019-06-07  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: longhand CSS properties overridden by shorthands miss strikethrough
>Index: Source/WebInspectorUI/UserInterface/Base/Utilities.js
>===================================================================
>--- Source/WebInspectorUI/UserInterface/Base/Utilities.js	(revision 246067)
>+++ Source/WebInspectorUI/UserInterface/Base/Utilities.js	(working copy)
>@@ -1637,7 +1637,7 @@ function isTextLikelyMinified(content)
> 
> function doubleQuotedString(str)
> {
>-    return "\"" + str.replace(/\\/g, "\\\\").replace(/"/g, "\\\"") + "\"";
>+    return JSON.stringify(str);
> }
> 
> function insertionIndexForObjectInListSortedByFunction(object, list, comparator, insertionIndexAfter)

Actions: View | Formatted Diff | Diff

Attachments on bug 198691: 371664 | 371668