WebKit Bugzilla
Attachment 371608 Details for
Bug 198677
: Update cached-svg-image-with-css-cross-domain.html and svg-image-with-css-cross-domain.html to use square instead of circle
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-198677-20190607135721.patch (text/plain), 13.54 KB, created by
youenn fablet
on 2019-06-07 13:57:22 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
youenn fablet
Created:
2019-06-07 13:57:22 PDT
Size:
13.54 KB
patch
obsolete
>Subversion Revision: 246170 >diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index 7de98c2caf4fdee30ee86026daa591e2d2c19615..5e0ccb80c296a290055d734eb5ad3874a548704c 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,24 @@ >+2019-06-07 Youenn Fablet <youenn@apple.com> >+ >+ Update cached-svg-image-with-css-cross-domain.html and svg-image-with-css-cross-domain.html to use square instead of circle >+ https://bugs.webkit.org/show_bug.cgi?id=198677 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Squares cause apparently less pixel issues with comparison than circle. >+ >+ * http/tests/security/cached-svg-image-with-css-cross-domain-expected.html: >+ * http/tests/security/cached-svg-image-with-css-cross-domain.html: >+ * http/tests/security/resources/image-with-css-cross-domain-rect.css: Renamed from LayoutTests/http/tests/security/resources/image-with-css-cross-domain-circle.css. >+ (rect): >+ * http/tests/security/resources/image-with-css-cross-domain-rect2.css: Renamed from LayoutTests/http/tests/security/resources/image-with-css-cross-domain-circle2.css. >+ (rect): >+ * http/tests/security/resources/image-with-css-cross-domain.svg: >+ * http/tests/security/svg-image-with-css-cross-domain-expected.html: >+ * http/tests/security/svg-image-with-css-cross-domain.css: >+ (span.rect-css-cross-domain): >+ * http/tests/security/svg-image-with-css-cross-domain.html: >+ > 2019-06-06 Youenn Fablet <youenn@apple.com> > > Call was negotiated with H264 Base Profile 42e01f but encoded in High Profile >diff --git a/LayoutTests/http/tests/security/cached-svg-image-with-css-cross-domain-expected.html b/LayoutTests/http/tests/security/cached-svg-image-with-css-cross-domain-expected.html >index 04bdd56b64af6fa3de4da72896b3080478d8a4a0..9ab7aa110d63154bbadd2763296ff5bf2c65e182 100644 >--- a/LayoutTests/http/tests/security/cached-svg-image-with-css-cross-domain-expected.html >+++ b/LayoutTests/http/tests/security/cached-svg-image-with-css-cross-domain-expected.html >@@ -5,19 +5,19 @@ > </head> > <body> > <h1>WebKit bug</h1> >- <h3>SVG circle with different-origin CSS. Ensure reuse caching over different origins work</h3> >- <p>Expected: 2 orange circles.</p> >+ <h3>SVG rect with different-origin CSS. Ensure reuse caching over different origins work</h3> >+ <p>Expected: 2 orange rects.</p> > <p> > <span class="image"> > <svg height="68" width="68" viewBox="-34 -34 68 68"> >- <circle cx="0" cy="0" r="24" stroke="red" stroke-width="2" fill="orange" /> >+ <rect x="0" y="0" width="24" height="24" stroke="red" stroke-width="2" fill="orange" /> > </svg> > </span> > </p> > <p> > <span class="image"> > <svg height="68" width="68" viewBox="-34 -34 68 68"> >- <circle cx="0" cy="0" r="24" stroke="red" stroke-width="2" fill="orange" /> >+ <rect x="0" y="0" width="24" height="24" stroke="red" stroke-width="2" fill="orange" /> > </svg> > </span> > </p> >diff --git a/LayoutTests/http/tests/security/cached-svg-image-with-css-cross-domain.html b/LayoutTests/http/tests/security/cached-svg-image-with-css-cross-domain.html >index 941cdf76b19c96126080cba2421e67ce620ac4ad..f49609676a56601cf8a0f430d18b04e7d58c42c8 100644 >--- a/LayoutTests/http/tests/security/cached-svg-image-with-css-cross-domain.html >+++ b/LayoutTests/http/tests/security/cached-svg-image-with-css-cross-domain.html >@@ -5,8 +5,8 @@ > </head> > <body> > <h1>WebKit bug</h1> >- <h3>SVG circle with different-origin CSS. Ensure reuse caching over different origins work</h3> >- <p>Expected: 2 orange circles.</p> >+ <h3>SVG rect with different-origin CSS. Ensure reuse caching over different origins work</h3> >+ <p>Expected: 2 orange rects.</p> > <script> > function onFirstFrameLoaded() > { >diff --git a/LayoutTests/http/tests/security/resources/image-with-css-cross-domain-circle.css b/LayoutTests/http/tests/security/resources/image-with-css-cross-domain-circle.css >deleted file mode 100644 >index 1f41f240ef36349752b62fcafe599263e3a22797..0000000000000000000000000000000000000000 >--- a/LayoutTests/http/tests/security/resources/image-with-css-cross-domain-circle.css >+++ /dev/null >@@ -1,3 +0,0 @@ >-circle { >- fill: orange; >-} >diff --git a/LayoutTests/http/tests/security/resources/image-with-css-cross-domain-circle2.css b/LayoutTests/http/tests/security/resources/image-with-css-cross-domain-circle2.css >deleted file mode 100644 >index 68fb960eb21499026c2c0851fa80a408c5ddeba7..0000000000000000000000000000000000000000 >--- a/LayoutTests/http/tests/security/resources/image-with-css-cross-domain-circle2.css >+++ /dev/null >@@ -1,4 +0,0 @@ >-circle { >- stroke: red; >- stroke-width: 2; >-} >diff --git a/LayoutTests/http/tests/security/resources/image-with-css-cross-domain-rect.css b/LayoutTests/http/tests/security/resources/image-with-css-cross-domain-rect.css >new file mode 100644 >index 0000000000000000000000000000000000000000..7169a775259b0371a66f615590f57fd79e27f81b >--- /dev/null >+++ b/LayoutTests/http/tests/security/resources/image-with-css-cross-domain-rect.css >@@ -0,0 +1,3 @@ >+rect { >+ fill: orange; >+} >diff --git a/LayoutTests/http/tests/security/resources/image-with-css-cross-domain-rect2.css b/LayoutTests/http/tests/security/resources/image-with-css-cross-domain-rect2.css >new file mode 100644 >index 0000000000000000000000000000000000000000..15d510eff891fc237bdf16a8bb182d978948a7e9 >--- /dev/null >+++ b/LayoutTests/http/tests/security/resources/image-with-css-cross-domain-rect2.css >@@ -0,0 +1,4 @@ >+rect { >+ stroke: red; >+ stroke-width: 2; >+} >diff --git a/LayoutTests/http/tests/security/resources/image-with-css-cross-domain.svg b/LayoutTests/http/tests/security/resources/image-with-css-cross-domain.svg >index 5cdcc9ccbad4f83bf076b7d2903ac4c643d32b5c..9ef2ecd8edc7a252a903f74322968796115636de 100644 >--- a/LayoutTests/http/tests/security/resources/image-with-css-cross-domain.svg >+++ b/LayoutTests/http/tests/security/resources/image-with-css-cross-domain.svg >@@ -1,6 +1,6 @@ > <?xml version="1.0" encoding="UTF-8" standalone="no"?> >-<?xml-stylesheet type="text/css" href="image-with-css-cross-domain-circle.css"?> >-<?xml-stylesheet type="text/css" href="http://localhost:8000/security/resources/image-with-css-cross-domain-circle2.css"?> >+<?xml-stylesheet type="text/css" href="image-with-css-cross-domain-rect.css"?> >+<?xml-stylesheet type="text/css" href="http://localhost:8000/security/resources/image-with-css-cross-domain-rect2.css"?> > <svg xmlns="http://www.w3.org/2000/svg" width="68" height="68" viewBox="-34 -34 68 68" > >- <circle cx="0" cy="0" r="24" fill="#c8c8c8"/> >+ <rect x="0" y="0" width="24" height="24" fill="#c8c8c8"/> > </svg> >diff --git a/LayoutTests/http/tests/security/svg-image-with-css-cross-domain-expected.html b/LayoutTests/http/tests/security/svg-image-with-css-cross-domain-expected.html >index 53fd08252b23541ced555c765dcc6e72ebb68b80..72947a0a7a5e864f8a68161ae263a93ec287bbda 100644 >--- a/LayoutTests/http/tests/security/svg-image-with-css-cross-domain-expected.html >+++ b/LayoutTests/http/tests/security/svg-image-with-css-cross-domain-expected.html >@@ -5,47 +5,47 @@ > </head> > <body> > <h1>WebKit bug</h1> >- <h3>SVG circle with same-origin and different-origin CSS</h3> >- <p>Expected: 2 gray circles, 4 orange circles with red borders, 2 gray circle.</p> >+ <h3>SVG rect with same-origin and different-origin CSS</h3> >+ <p>Expected: 2 gray rects, 4 orange rects with red borders, 2 gray rects.</p> > <p> > <span class="image"> > <svg height="68" width="68" viewBox="-34 -34 68 68"> >- <circle cx="0" cy="0" r="24" fill="#c8c8c8" /> >+ <rect x="0" y="0" width="24" height="24" fill="#c8c8c8" /> > </svg> > </span> > <span class="image"> > <svg height="68" width="68" viewBox="-34 -34 68 68"> >- <circle cx="0" cy="0" r="24" fill="#c8c8c8" /> >+ <rect x="0" y="0" width="24" height="24" fill="#c8c8c8" /> > </svg> > </span> > <span class="image"> > <svg height="68" width="68" viewBox="-34 -34 68 68"> >- <circle cx="0" cy="0" r="24" stroke="red" stroke-width="2" fill="orange" /> >+ <rect x="0" y="0" width="24" height="24" stroke="red" stroke-width="2" fill="orange" /> > </svg> > </span> > <span class="image"> > <svg height="68" width="68" viewBox="-34 -34 68 68"> >- <circle cx="0" cy="0" r="24" stroke="red" stroke-width="2" fill="orange" /> >+ <rect x="0" y="0" width="24" height="24" stroke="red" stroke-width="2" fill="orange" /> > </svg> > </span> > <span class="image"> > <svg height="68" width="68" viewBox="-34 -34 68 68"> >- <circle cx="0" cy="0" r="24" stroke="red" stroke-width="2" fill="orange" /> >+ <rect x="0" y="0" width="24" height="24" stroke="red" stroke-width="2" fill="orange" /> > </svg> > </span> > <span class="image"> > <svg height="68" width="68" viewBox="-34 -34 68 68"> >- <circle cx="0" cy="0" r="24" stroke="red" stroke-width="2" fill="orange" /> >+ <rect x="0" y="0" width="24" height="24" stroke="red" stroke-width="2" fill="orange" /> > </svg> > </span> > <span class="image"> > <svg height="68" width="68" viewBox="-34 -34 68 68"> >- <circle cx="0" cy="0" r="24" fill="#c8c8c8" /> >+ <rect x="0" y="0" width="24" height="24" fill="#c8c8c8" /> > </svg> > </span> > <span class="image"> > <svg height="68" width="68" viewBox="-34 -34 68 68"> >- <circle cx="0" cy="0" r="24" fill="#c8c8c8" /> >+ <rect x="0" y="0" width="24" height="24" fill="#c8c8c8" /> > </svg> > </span> > </p> >diff --git a/LayoutTests/http/tests/security/svg-image-with-css-cross-domain.css b/LayoutTests/http/tests/security/svg-image-with-css-cross-domain.css >index fe54dea1b180470528ce1fc56ebafdd9436b6d2f..cd0b90c130c3609e1c62ffd75038eb48b4ba245d 100644 >--- a/LayoutTests/http/tests/security/svg-image-with-css-cross-domain.css >+++ b/LayoutTests/http/tests/security/svg-image-with-css-cross-domain.css >@@ -4,7 +4,7 @@ span { > width: 68px; > } > >-span.circle-css-cross-domain { >+span.rect-css-cross-domain { > background-image: url('resources/image-with-css-cross-domain.svg'); > } > >diff --git a/LayoutTests/http/tests/security/svg-image-with-css-cross-domain.html b/LayoutTests/http/tests/security/svg-image-with-css-cross-domain.html >index 92f27c2488876ac5887a5ab5967762723cba0e3a..a44af1f79fba85322ebec7b98102fa726c604770 100644 >--- a/LayoutTests/http/tests/security/svg-image-with-css-cross-domain.html >+++ b/LayoutTests/http/tests/security/svg-image-with-css-cross-domain.html >@@ -5,22 +5,22 @@ > </head> > <body> > <h1>WebKit bug</h1> >- <h3>SVG circle with same-origin and different-origin CSS</h3> >- <p>Expected: 2 gray circles, 4 orange circles with red borders, 2 gray circle.</p> >+ <h3>SVG rect with same-origin and different-origin CSS</h3> >+ <p>Expected: 2 gray rects, 4 orange rects with red borders, 2 gray rects.</p> > <p> >- <span class="image"><img src="resources/image-with-css-cross-domain.svg" alt="circle" width="68" height="68"/></span> >- <span class="image circle-css-cross-domain"></span> >+ <span class="image"><img src="resources/image-with-css-cross-domain.svg" alt="rect" width="68" height="68"/></span> >+ <span class="image rect-css-cross-domain"></span> > <object data="resources/image-with-css-cross-domain.svg" type="image/svg+xml" width="68" height="68"></object> > <embed src="resources/image-with-css-cross-domain.svg" type="image/svg+xml" width="68" height="68"></embed> > <iframe src="resources/image-with-css-cross-domain.svg" width="68" height="68"></iframe> > <iframe src="resources/image-with-css-cross-domain.svg" width="68" height="68" sandbox=""></iframe> >- <span class="image"><img width="68" height="68" alt="circle" src="data:image/svg+xml;charset=utf-8;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiIHN0YW5kYWxvbmU9Im5vIj8+DQo8P3htbC1zdHlsZXNoZWV0IHR5cGU9InRleHQvY3NzIiBocmVmPSJjaXJjbGUuY3NzIj8+DQo8P3htbC1zdHlsZXNoZWV0IHR5cGU9InRleHQvY3NzIiBocmVmPSJodHRwOi8vZG9tMi5jaHJvbWVidWcyLnRlc3QvY2lyY2xlMi5jc3MiPz4NCjxzdmcNCiAgIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyINCiAgIHdpZHRoPSI2OCINCiAgIGhlaWdodD0iNjgiDQogICB2aWV3Qm94PSItMzQgLTM0IDY4IDY4Ig0KICAgdmVyc2lvbj0iMS4xIj4NCiAgPGNpcmNsZQ0KICAgICBjeD0iMCINCiAgICAgY3k9IjAiDQogICAgIHI9IjI0Ig0KICAgICBmaWxsPSIjYzhjOGM4Ii8+DQo8L3N2Zz4="/></span> >+ <span class="image"><img width="68" height="68" alt="rect" src="data:image/svg+xml;charset=utf-8;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiIHN0YW5kYWxvbmU9Im5vIj8+Cjw/eG1sLXN0eWxlc2hlZXQgdHlwZT0idGV4dC9jc3MiIGhyZWY9InJlY3QuY3NzIj8+CjxzdmcKICAgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIgogICB3aWR0aD0iNjgiCiAgIGhlaWdodD0iNjgiCiAgIHZpZXdCb3g9Ii0zNCAtMzQgNjggNjgiCiAgIHZlcnNpb249IjEuMSI+CiAgPHJlY3QKICAgICB4PSIwIgogICAgIHk9IjAiCiAgICAgaGVpZ2h0PSIyNCIKICAgICB3aWR0aD0iMjQiCiAgICAgZmlsbD0iI2M4YzhjOCIvPgo8L3N2Zz4="/></span> > <span class="image"> > <?xml version="1.0" encoding="UTF-8" standalone="no"?> >- <?xml-stylesheet type="text/css" href="circle.css"?> >- <?xml-stylesheet type="text/css" href="http://localhost:8000/security/circle2.css"?> >+ <?xml-stylesheet type="text/css" href="rect.css"?> >+ <?xml-stylesheet type="text/css" href="http://localhost:8000/security/rect2.css"?> > <svg xmlns="http://www.w3.org/2000/svg" width="68" height="68" viewBox="-34 -34 68 68" version="1.1"> >- <circle cx="0" cy="0" r="24" fill="#c8c8c8"/> >+ <rect x="0" y="0" width="24" height="24" fill="#c8c8c8"/> > </svg> > </span> > </p>
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=371608">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 198677
: 371608