Attachment 371605 Details for Bug 198675 – Patch

[patch] Patch

bug-198675-20190607133013.patch (text/plain), 2.58 KB, created by Keith Rollin on 2019-06-07 13:30:14 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Rollin

Created: 2019-06-07 13:30:14 PDT

Size: 2.58 KB

patch

obsolete

>Subversion Revision: 246210
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index e7796e197e0b351c296f4cacd9086c4310cf097a..5d20482caaa19f52e4627cf5137814167c413c85 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-06-07  Keith Rollin  <krollin@apple.com>
>+
>+        Open up xcfilelist processing to more platforms
>+        https://bugs.webkit.org/show_bug.cgi?id=198675
>+        <rdar://problem/51533238>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Now that it's been tested, add AppleTV{OS,Simulator} to the set of
>+        platforms on which to perform xcfilelist generation/updating.
>+
>+        * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
>+        (JavaScriptCoreGenerator):
>+        (WebCoreGenerator):
>+        (WebKitGenerator):
>+
> 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [iOS] At least 6 API tests are failing due to an exception when writing NSAttributedString to the pasteboard
>diff --git a/Tools/Scripts/webkitpy/generate_xcfilelists_lib/generators.py b/Tools/Scripts/webkitpy/generate_xcfilelists_lib/generators.py
>index d862d4f1da87365dd00dd5882cc8e087d6edc5f6..cf6745be7c666de0f9c5396d61016c85db088c16 100644
>--- a/Tools/Scripts/webkitpy/generate_xcfilelists_lib/generators.py
>+++ b/Tools/Scripts/webkitpy/generate_xcfilelists_lib/generators.py
>@@ -648,7 +648,7 @@ class BaseGenerator(object):
> 
> 
> class JavaScriptCoreGenerator(BaseGenerator):
>-    VALID_PLATFORMS = ("macosx", "iosmac", "iphoneos", "iphonesimulator", "watchos", "watchsimulator")
>+    VALID_PLATFORMS = ("macosx", "iosmac", "iphoneos", "iphonesimulator", "watchos", "watchsimulator", "appletvos", "appletvsimulator")
>     VALID_CONFIGURATIONS = ("Debug", "Release", "Production", "Profiling")
> 
>     @util.LogEntryExit
>@@ -665,7 +665,7 @@ class JavaScriptCoreGenerator(BaseGenerator):
> 
> 
> class WebCoreGenerator(BaseGenerator):
>-    VALID_PLATFORMS = ("macosx", "iosmac", "iphoneos", "iphonesimulator", "watchos", "watchsimulator")
>+    VALID_PLATFORMS = ("macosx", "iosmac", "iphoneos", "iphonesimulator", "watchos", "watchsimulator", "appletvos", "appletvsimulator")
>     VALID_CONFIGURATIONS = ("Debug", "Release", "Production")
> 
>     @util.LogEntryExit
>@@ -682,7 +682,7 @@ class WebCoreGenerator(BaseGenerator):
> 
> 
> class WebKitGenerator(BaseGenerator):
>-    VALID_PLATFORMS = ("macosx", "iosmac", "iphoneos", "iphonesimulator", "watchos", "watchsimulator")
>+    VALID_PLATFORMS = ("macosx", "iosmac", "iphoneos", "iphonesimulator", "watchos", "watchsimulator", "appletvos", "appletvsimulator")
>     VALID_CONFIGURATIONS = ("Debug", "Release", "Production")
> 
>     @util.LogEntryExit

Actions: View | Formatted Diff | Diff

Attachments on bug 198675: 371605