Attachment 371601 Details for Bug 196445 – Patch

[patch] Patch

bug-196445-20190607111059.patch (text/plain), 3.12 KB, created by youenn fablet on 2019-06-07 11:11:00 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-06-07 11:11:00 PDT

Size: 3.12 KB

patch

obsolete

>Subversion Revision: 246170
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 7de98c2caf4fdee30ee86026daa591e2d2c19615..7226f8bf14984415f147253977c021abd12cab1a 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-06-07  Youenn Fablet  <youenn@apple.com>
>+
>+        [ Mac Debug ] REGRESSION (r242975) Layout Test storage/indexeddb/modern/deletedatabase-2-private.html is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=196445
>+        <rdar://problem/49483061>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Unflake the test by making sure to wait for the onerror event before continuing the test.
>+
>+        * platform/mac-wk2/TestExpectations:
>+        * storage/indexeddb/modern/resources/deletedatabase-2.js:
>+        (prepareDatabase.event.target.onerror):
>+        (continueTest1.request.onsuccess): Deleted.
>+
> 2019-06-06  Youenn Fablet  <youenn@apple.com>
> 
>         Call was negotiated with H264 Base Profile 42e01f but encoded in High Profile
>diff --git a/LayoutTests/platform/mac-wk2/TestExpectations b/LayoutTests/platform/mac-wk2/TestExpectations
>index 113e92d124dfa39b8aa9435ac391e9ea1527f380..5414242aab5d6d0ba35e2d0f702306a8b94e96ae 100644
>--- a/LayoutTests/platform/mac-wk2/TestExpectations
>+++ b/LayoutTests/platform/mac-wk2/TestExpectations
>@@ -950,8 +950,6 @@ webkit.org/b/197289 [ Mojave Debug ] webgl/2.0.0/conformance/state/gl-object-get
> 
> webkit.org/b/189672 [ Mojave Debug ] webgl/2.0.0/conformance2/textures/misc/tex-new-formats.html [ Skip ]
> 
>-webkit.org/b/196445 [ Debug ] storage/indexeddb/modern/deletedatabase-2-private.html [ Pass Failure ]
>-
> webkit.org/b/198195 [ Release ] fast/css/sticky/sticky-left-percentage.html [ Pass ImageOnlyFailure ]
> 
> webkit.org/b/187828 [ Release ] fast/css-grid-layout/flex-content-sized-columns-resize.html [ Pass ImageOnlyFailure ]
>diff --git a/LayoutTests/storage/indexeddb/modern/resources/deletedatabase-2.js b/LayoutTests/storage/indexeddb/modern/resources/deletedatabase-2.js
>index 377859d8a8d801707e3d12c2e11ede497954d5cb..3051523ce6bfa9f6cb494f5127b3640a458a6006 100644
>--- a/LayoutTests/storage/indexeddb/modern/resources/deletedatabase-2.js
>+++ b/LayoutTests/storage/indexeddb/modern/resources/deletedatabase-2.js
>@@ -21,12 +21,16 @@ function successCallback()
> }
> 
> var dbname;
>+var resolveTransactionPromise;
>+var transactionPromise = new Promise(resolve => resolveTransactionPromise = resolve);
>+
> function prepareDatabase(e)
> {
>     debug("Initial upgrade old version - " + e.oldVersion + " new version - " + e.newVersion);
>     
>     event.target.onerror = function(e) {
>         debug("Open request error: " + event.target.error.name);
>+        resolveTransactionPromise();
>     }
> 
>     var versionTransaction = event.target.transaction;
>@@ -76,8 +80,9 @@ function continueTest1()
> {
>     debug("Requesting deleteDatabase");
>     var request = window.indexedDB.deleteDatabase(dbname);
>-    request.onsuccess = function(e)
>+    request.onsuccess = async function(e)
>     {
>+        await transactionPromise;
>         debug("Delete database success: oldVersion " + e.oldVersion + ", newVersion " + e.newVersion);
>         continueTest2();
>     }

Actions: View | Formatted Diff | Diff

Attachments on bug 196445: 371601