Attachment 371599 Details for Bug 198668 – Patch

[patch] Patch

bug-198668-20190607105624.patch (text/plain), 1.34 KB, created by youenn fablet on 2019-06-07 10:56:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-06-07 10:56:25 PDT

Size: 1.34 KB

patch

obsolete

>Subversion Revision: 246170
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 4eee4ee7c77358b5d9ee202806d0267a3b07ab6b..6f1a9fb8041e9eb673265d764a4058ef69d371f5 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-07  Youenn Fablet  <youenn@apple.com>
>+
>+        Add a RELEASE_ASSERT that removeAudioProducer should always be done in the main thread
>+        https://bugs.webkit.org/show_bug.cgi?id=198668
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        See rdar://problem/49444622 for background information.
>+        No change of behavior.
>+
>+        * dom/Document.cpp:
>+        (WebCore::Document::removeAudioProducer):
>+
> 2019-06-07  Youenn Fablet  <youenn@apple.com>
> 
>         mediaDevices.enumerateDevices() doesn't list the system default audio devices with deviceId as "default"
>diff --git a/Source/WebCore/dom/Document.cpp b/Source/WebCore/dom/Document.cpp
>index ea6ba533986725f7aed6c94f3819737d9a096830..ba3c36529d0d931eac23488d23052c2ce13208bb 100644
>--- a/Source/WebCore/dom/Document.cpp
>+++ b/Source/WebCore/dom/Document.cpp
>@@ -3933,6 +3933,7 @@ void Document::addAudioProducer(MediaProducer& audioProducer)
> 
> void Document::removeAudioProducer(MediaProducer& audioProducer)
> {
>+    RELEASE_ASSERT(isMainThread());
>     m_audioProducers.remove(audioProducer);
>     updateIsPlayingMedia();
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 198668: 371599