Attachment 371577 Details for Bug 198653 – Patch

[patch] Patch

bug-198653-20190607114904.patch (text/plain), 2.18 KB, created by Keith Miller on 2019-06-07 02:49:05 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Miller

Created: 2019-06-07 02:49:05 PDT

Size: 2.18 KB

patch

obsolete

>Subversion Revision: 246194
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 4615ea2cfd989f912ada374f138af1a30ab94ce0..d6c8912115e8d7387894a5150628f72022430d14 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-06-07  Keith Miller  <keith_miller@apple.com>
>+
>+        Disable wasm signaling memories on iOS.
>+        https://bugs.webkit.org/show_bug.cgi?id=198653
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * runtime/Options.h:
>+
> 2019-06-06  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: create CommandLineAPIHost lazily like the other agents
>diff --git a/Source/JavaScriptCore/runtime/Options.h b/Source/JavaScriptCore/runtime/Options.h
>index 14c9b5663e54c5ed59ea9ac6d6dcc059a8026126..3c6905fe8104977d8bea78fd83d0034c8d98431e 100644
>--- a/Source/JavaScriptCore/runtime/Options.h
>+++ b/Source/JavaScriptCore/runtime/Options.h
>@@ -492,7 +492,8 @@ constexpr bool enableWebAssemblyStreamingApi = false;
>     v(unsigned, webAssemblyLoopDecrement, 15, Normal, "The amount the tier up countdown is decremented on each loop backedge.") \
>     v(unsigned, webAssemblyFunctionEntryDecrement, 1, Normal, "The amount the tier up countdown is decremented on each function entry.") \
>     \
>-    v(bool, useWebAssemblyFastMemory, true, Normal, "If true, we will try to use a 32-bit address space with a signal handler to bounds check wasm memory.") \
>+    /* FIXME: enable fast memories on iOS and pre-allocate them. https://bugs.webkit.org/show_bug.cgi?id=170774 */ \
>+    v(bool, useWebAssemblyFastMemory, !isIOS(), Normal, "If true, we will try to use a 32-bit address space with a signal handler to bounds check wasm memory.") \
>     v(bool, logWebAssemblyMemory, false, Normal, nullptr) \
>     v(unsigned, webAssemblyFastMemoryRedzonePages, 128, Normal, "WebAssembly fast memories use 4GiB virtual allocations, plus a redzone (counted as multiple of 64KiB WebAssembly pages) at the end to catch reg+imm accesses which exceed 32-bit, anything beyond the redzone is explicitly bounds-checked") \
>     v(bool, crashIfWebAssemblyCantFastMemory, false, Normal, "If true, we will crash if we can't obtain fast memory for wasm.") \

Flags:

ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 198653: 371577 | 371586