Attachment 371542 Details for Bug 198636 – ROLLOUT of r246165

[patch] ROLLOUT of r246165

bug-198636-20190606172817.patch (text/plain), 7.58 KB, created by WebKit Commit Bot on 2019-06-06 17:28:17 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: WebKit Commit Bot

Created: 2019-06-06 17:28:17 PDT

Size: 7.58 KB

patch

obsolete

>Subversion Revision: 246182
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index e7312f3c41196ff84eb9617750150c79a0b7a09b..5bb5a69e855a277df0b11c7fecde5d815c0e8004 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-06-06  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r246165.
>+        https://bugs.webkit.org/show_bug.cgi?id=198636
>+
>+        Causing test failures in 7 content-observation tests.
>+        (Requested by ShawnRoberts on #webkit).
>+
>+        Reverted changeset:
>+
>+        "Restrict fast clicks everywhere to desktop content mode"
>+        https://bugs.webkit.org/show_bug.cgi?id=198610
>+        https://trac.webkit.org/changeset/246165
>+
> 2019-06-06  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r246123.
>diff --git a/Source/WebKit/UIProcess/WebPageProxy.h b/Source/WebKit/UIProcess/WebPageProxy.h
>index caa0d19ce49537e0f143ccf0ca24e6ef3b771f27..1cf8b6e892d1648755c59ddec636d082f576511e 100644
>--- a/Source/WebKit/UIProcess/WebPageProxy.h
>+++ b/Source/WebKit/UIProcess/WebPageProxy.h
>@@ -518,8 +518,6 @@ public:
> 
>     bool hasCommittedAnyProvisionalLoads() const { return m_hasCommittedAnyProvisionalLoads; }
> 
>-    bool allowsFastClicksEverywhere() const { return m_allowsFastClicksEverywhere; }
>-
>     void setIsUsingHighPerformanceWebGL(bool value) { m_isUsingHighPerformanceWebGL = value; }
>     bool isUsingHighPerformanceWebGL() const { return m_isUsingHighPerformanceWebGL; }
> 
>@@ -2480,7 +2478,6 @@ WEBPAGEPROXY_LOADOPTIMIZER_ADDITIONS_2
>     bool m_isUsingHighPerformanceWebGL { false };
>     bool m_openedByDOM { false };
>     bool m_hasCommittedAnyProvisionalLoads { false };
>-    bool m_allowsFastClicksEverywhere { false };
> 
>     HashMap<String, Ref<WebURLSchemeHandler>> m_urlSchemeHandlersByScheme;
>     HashMap<uint64_t, Ref<WebURLSchemeHandler>> m_urlSchemeHandlersByIdentifier;
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index 0d73896b8c98649137a8b32853814d7208a31870..9a6d214e4bc98eaf2ad3c30dda8d8c92a7fe555c 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -1587,7 +1587,7 @@ static NSValue *nsSizeForTapHighlightBorderRadius(WebCore::IntSize borderRadius,
>     if (!_potentialTapInProgress)
>         return;
> 
>-    if (_page->preferences().fastClicksEverywhere() && _page->allowsFastClicksEverywhere()) {
>+    if (_page->preferences().fastClicksEverywhere()) {
>         RELEASE_LOG(ViewGestures, "Potential tap found an element and fast taps are forced on. Trigger click. (%p)", self);
>         [self _setDoubleTapGesturesEnabled:NO];
>         return;
>diff --git a/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm b/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
>index 3b1800f8e32d4e27775e8568c9d5b88fc00de158..3b46da2a60a763827a4c8a2a6e59554154b0626d 100644
>--- a/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
>+++ b/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
>@@ -1376,8 +1376,6 @@ WebContentMode WebPageProxy::effectiveContentModeAfterAdjustingPolicies(API::Web
>         break;
>     }
> 
>-    m_allowsFastClicksEverywhere = false;
>-
>     if (!useDesktopBrowsingMode)
>         return WebContentMode::Mobile;
> 
>@@ -1399,7 +1397,6 @@ WebContentMode WebPageProxy::effectiveContentModeAfterAdjustingPolicies(API::Web
>         policies.setMediaSourcePolicy(WebsiteMediaSourcePolicy::Enable);
>         policies.setSimulatedMouseEventsDispatchPolicy(WebsiteSimulatedMouseEventsDispatchPolicy::Allow);
>         policies.setLegacyOverflowScrollingTouchPolicy(WebsiteLegacyOverflowScrollingTouchPolicy::Disable);
>-        m_allowsFastClicksEverywhere = true;
>     }
> 
>     return WebContentMode::Desktop;
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 1bd65d42e910fda806d0d67343dc977131ce5040..c63784eda3f1eceb82bb6c031dabf2e42ec825c4 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-06-06  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r246165.
>+        https://bugs.webkit.org/show_bug.cgi?id=198636
>+
>+        Causing test failures in 7 content-observation tests.
>+        (Requested by ShawnRoberts on #webkit).
>+
>+        Reverted changeset:
>+
>+        "Restrict fast clicks everywhere to desktop content mode"
>+        https://bugs.webkit.org/show_bug.cgi?id=198610
>+        https://trac.webkit.org/changeset/246165
>+
> 2019-06-06  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Formatter: pretty-print CSS using a Worker
>diff --git a/LayoutTests/fast/events/ios/ipad/fast-click-always-mobile-content-mode-expected.txt b/LayoutTests/fast/events/ios/ipad/fast-click-always-mobile-content-mode-expected.txt
>deleted file mode 100644
>index d79b6fc4bd7eca0340644981a51f6640bec64582..0000000000000000000000000000000000000000
>--- a/LayoutTests/fast/events/ios/ipad/fast-click-always-mobile-content-mode-expected.txt
>+++ /dev/null
>@@ -1,2 +0,0 @@
>-PASS: Double tap caused zoom.
>-This document doesn't have fast clicks because it sets a viewport width. It has a significant zoom since the viewport width is significantly bigger than the body width. However, although fast click everywhere is set to false, the content mode is also set to mobile which disables fast click everywhere, so double tapping on the rectangle above should zoom.
>diff --git a/LayoutTests/fast/events/ios/ipad/fast-click-always-mobile-content-mode.html b/LayoutTests/fast/events/ios/ipad/fast-click-always-mobile-content-mode.html
>deleted file mode 100644
>index c43b8e8d31fb76dd163fb4bcba9684fcf190ed09..0000000000000000000000000000000000000000
>--- a/LayoutTests/fast/events/ios/ipad/fast-click-always-mobile-content-mode.html
>+++ /dev/null
>@@ -1,59 +0,0 @@
>-<!DOCTYPE html> 
>-
>-<html>
>-<meta name="viewport" content="width=800">
>-<head>
>-    <style>
>-        body {
>-            font-family: system-ui;
>-            line-height: 1.4;
>-            padding: 10px 10px;
>-            width: 500px;
>-            margin: 0;
>-        }
>-    </style>
>-    <script src="../../../../resources/ui-helper.js"></script>
>-    <script>
>-        if (window.testRunner) {
>-            testRunner.dumpAsText();
>-            testRunner.waitUntilDone();
>-        }
>-
>-        async function runTest()
>-        {
>-            document.getElementById("target").addEventListener("click", handleClick, false);
>-
>-            if (!window.testRunner)
>-                return;
>-
>-            await UIHelper.humanSpeedZoomByDoubleTappingAt(30, 30);
>-            document.getElementById("target").textContent = "PASS: Double tap caused zoom.";
>-            testRunner.notifyDone();
>-        }
>-
>-        function handleClick(event)
>-        {
>-            document.getElementById("target").textContent = "FAIL: Click fired on element with handler.";
>-            testRunner.notifyDone();
>-        }
>-    </script>
>-    <style>
>-        body {
>-            margin: 0;
>-        }
>-        #target {
>-            height: 100px;
>-            width: 100px;
>-            background-color: silver;
>-        }
>-    </style>
>-</head>
>-<body onload="runTest()">
>-<div id="target"></div>
>-<div id="description">This document doesn't have fast clicks because
>-    it sets a viewport width. It has a significant zoom since the viewport
>-    width is significantly bigger than the body width. However, although fast click
>-    everywhere is set to false, the content mode is also set to mobile which disables
>-    fast click everywhere, so double tapping on the rectangle above should zoom.</div>
>-</body>
>-</html>

Actions: View | Formatted Diff | Diff

Attachments on bug 198636: 371542