Attachment 371519 Details for Bug 198620 – Patch

[patch] Patch

bug-198620-20190606122332.patch (text/plain), 2.55 KB, created by Daniel Bates on 2019-06-06 12:23:33 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2019-06-06 12:23:33 PDT

Size: 2.55 KB

patch

obsolete

>Subversion Revision: 246069
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 6e9aade54c0d5037cb395748f70c437cb1f122ad..6cc379270a9fbb2f90f5ea3dd594a99074728d3a 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,26 @@
>+2019-06-06  Daniel Bates  <dabates@apple.com>
>+
>+        [lldb-webkit] Pretty-print all kinds of Documents
>+        https://bugs.webkit.org/show_bug.cgi?id=198620
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Register formatters for all classes derived from WebCore::Document so we get nice summaries
>+        without having to drill down in Xcode- or casting- to the base class, Document.
>+
>+        Older LLDB versions use to do this automatically, but this functionality was removed in newer
>+        versions:
>+            [[
>+                Warning: previous versions of LLDB defined cascading to mean not only going through typedef
>+                chains, but also through inheritance chains. This feature has been removed since it
>+                significantly degrades performance. You need to set up your formatters for every type in
>+                inheritance chains to which you want the formatter to apply.
>+            ]]
>+            <https://lldb.llvm.org/use/variable.html> (as of 06/06/2019)
>+
>+        * lldb/lldb_webkit.py:
>+        (__lldb_init_module):
>+
> 2019-06-06  Daniel Bates  <dabates@apple.com>
> 
>         [lldb-webkit] TypeError: cannot concatenate 'str' and 'int' objects when prettify URL with port number
>diff --git a/Tools/lldb/lldb_webkit.py b/Tools/lldb/lldb_webkit.py
>index 5eb2d88aab36a7458a86fcc47bb2b34c2fd0f3b3..8a6c9e47e2130d57b42dcb5784fbcc2aa989e4bb 100644
>--- a/Tools/lldb/lldb_webkit.py
>+++ b/Tools/lldb/lldb_webkit.py
>@@ -85,7 +85,9 @@ def __lldb_init_module(debugger, dict):
> 
>     debugger.HandleCommand('type summary add -F lldb_webkit.WebCoreSecurityOrigin_SummaryProvider WebCore::SecurityOrigin')
>     debugger.HandleCommand('type summary add -F lldb_webkit.WebCoreFrame_SummaryProvider WebCore::Frame')
>-    debugger.HandleCommand('type summary add -F lldb_webkit.WebCoreDocument_SummaryProvider WebCore::Document')
>+
>+    for className in ['Document', 'FTPDirectoryDocument', 'HTMLDocument', 'ImageDocument', 'MediaDocument', 'PluginDocument', 'SVGDocument', 'SinkDocument', 'TextDocument', 'XMLDocument']:
>+        debugger.HandleCommand('type summary add -F lldb_webkit.WebCoreDocument_SummaryProvider WebCore::' + className)
> 
>     # synthetic types (see <https://lldb.llvm.org/varformats.html>)
>     debugger.HandleCommand('type synthetic add -x "^WTF::Vector<.+>$" --python-class lldb_webkit.WTFVectorProvider')

Actions: View | Formatted Diff | Diff

Attachments on bug 198620: 371519