Attachment 371512 Details for Bug 198614 – Patch

[patch] Patch

bug-198614-20190606191330.patch (text/plain), 1.81 KB, created by Philippe Normand on 2019-06-06 11:13:32 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Philippe Normand

Created: 2019-06-06 11:13:32 PDT

Size: 1.81 KB

patch

obsolete

>Subversion Revision: 246150
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 3f26b0dc77ef72c420d3a6144ca65bd57e045c7b..15faa9d3d250c1d74890e3ab70b5382a94debb21 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-06-06  Philippe Normand  <pnormand@igalia.com>
>+
>+        [GStreamer] videorate issues with v4l2src
>+        https://bugs.webkit.org/show_bug.cgi?id=198614
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Configure videorate to cope with the live stream provided by the
>+        source element. Not doing so might lead to errors in the v4l2
>+        buffer allocator.
>+
>+        * platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
>+        (WebCore::GStreamerVideoCapturer::createConverter):
>+
> 2019-06-05  Takashi Komori  <Takashi.Komori@sony.com>
> 
>         [Curl] Report all request headers to web inspector.
>diff --git a/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp b/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp
>index 67cc5f3b2416918603e976869a2950468d8a064d..ef8e0163f1d3a8aa713baf91fb1ce5b71ead2054 100644
>--- a/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp
>+++ b/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp
>@@ -38,8 +38,8 @@ GStreamerVideoCapturer::GStreamerVideoCapturer(const char* sourceFactory)
> 
> GstElement* GStreamerVideoCapturer::createConverter()
> {
>-    auto converter = gst_parse_bin_from_description("videoscale ! videoconvert ! videorate", TRUE, nullptr);
>-
>+    // https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/97#note_56575
>+    auto converter = gst_parse_bin_from_description("videoscale ! videoconvert ! videorate drop-only=1 average-period=1", TRUE, nullptr);
>     ASSERT(converter);
> 
>     return converter;

Flags:

calvaris: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 198614: 371512