Attachment 371434 Details for Bug 198014 – Patch

[patch] Patch

bug-198014-20190605152923.patch (text/plain), 2.07 KB, created by Michael Catanzaro on 2019-06-05 13:29:24 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2019-06-05 13:29:24 PDT

Size: 2.07 KB

patch

obsolete

>Subversion Revision: 246117
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 9157c54a2d7b3a24a24d585dd13efebdc55e3b17..9b61c67d7531e7cdb398e13ae20a61f0d602b212 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-06-05  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        aarch64: âJSC::ARM64Assembler::LinkRecord::<unnamed union>::RealTypes::m_compareRegisterâ is too small to hold all values of âJSC::ARM64Assembler::RegisterIDâ {aka âenum JSC::ARM64Registers::RegisterIDâ}
>+        https://bugs.webkit.org/show_bug.cgi?id=198014
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        When building for aarch64, there is a huge warning spam here. It's impossible to see any
>+        other warnings. This has been ongoing for so long I've begun to suspect that nobody works
>+        on this architecture.
>+
>+        Anyway, the problem is because we need eight bits to store all possible RegisterID values,
>+        but the bitfield is only six bits wide. Fix it. The COMPILE_ASSERT checking the size of this
>+        struct is still happy, so I presume the change is OK.
>+
>+        * assembler/ARM64Assembler.h:
>+
> 2019-06-04  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         Fix miscellaneous build warnings
>diff --git a/Source/JavaScriptCore/assembler/ARM64Assembler.h b/Source/JavaScriptCore/assembler/ARM64Assembler.h
>index 6fd628a25866fb4fb96fd50a14d074b495fd487e..544b612c345be959669b1a276de55a1e2d488250 100644
>--- a/Source/JavaScriptCore/assembler/ARM64Assembler.h
>+++ b/Source/JavaScriptCore/assembler/ARM64Assembler.h
>@@ -458,11 +458,11 @@ public:
>             struct RealTypes {
>                 int64_t m_from;
>                 int64_t m_to;
>+                RegisterID m_compareRegister;
>                 JumpType m_type : 8;
>                 JumpLinkType m_linkType : 8;
>                 Condition m_condition : 4;
>                 unsigned m_bitNumber : 6;
>-                RegisterID m_compareRegister : 6;
>                 bool m_is64Bit : 1;
>             } realTypes;
>             struct CopyTypes {

Actions: View | Formatted Diff | Diff

Attachments on bug 198014: 371434