Attachment 371425 Details for Bug 198575 – Patch

[patch] Patch

bug-198575-20190605113049.patch (text/plain), 2.41 KB, created by youenn fablet on 2019-06-05 11:30:50 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-06-05 11:30:50 PDT

Size: 2.41 KB

patch

obsolete

>Subversion Revision: 246034
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 667f8d71f26e57044e3c73c6c6491c321b0562d6..59dc32c62df2e78fb8b5a9782b4cb97d83cf6683 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-06-05  Youenn Fablet  <youenn@apple.com>
>+
>+        Remove logSiteIdentifier from UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame
>+        https://bugs.webkit.org/show_bug.cgi?id=198575
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
>+        (WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
>+
> 2019-06-04  Youenn Fablet  <youenn@apple.com>
> 
>         Use an enumeration in UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo callback
>diff --git a/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp b/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
>index 4711fccff41ff13dcbacebc120f34bb777d933ed..93e2f7820145704e275e7a164b546d32dddeb16c 100644
>--- a/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
>+++ b/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
>@@ -340,12 +340,10 @@ UserMediaPermissionRequestManagerProxy::RequestAction UserMediaPermissionRequest
> void UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame(uint64_t userMediaID, uint64_t frameID, Ref<SecurityOrigin>&& userMediaDocumentOrigin, Ref<SecurityOrigin>&& topLevelDocumentOrigin, MediaStreamRequest&& userRequest)
> {
> #if ENABLE(MEDIA_STREAM)
>-    auto logSiteIdentifier = LOGIDENTIFIER;
>-
>     if (!m_page.hasRunningProcess())
>         return;
> 
>-    ALWAYS_LOG(logSiteIdentifier, userMediaID);
>+    ALWAYS_LOG(LOGIDENTIFIER, userMediaID);
> 
>     auto request = UserMediaPermissionRequestProxy::create(*this, userMediaID, m_page.mainFrame()->frameID(), frameID, WTFMove(userMediaDocumentOrigin), WTFMove(topLevelDocumentOrigin), { }, { }, WTFMove(userRequest));
>     if (m_currentUserMediaRequest) {
>@@ -354,7 +352,7 @@ void UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame(
>     }
> 
>     if (!UserMediaProcessManager::singleton().captureEnabled()) {
>-        ALWAYS_LOG(logSiteIdentifier, "capture disabled");
>+        ALWAYS_LOG(LOGIDENTIFIER, "capture disabled");
>         m_pendingRejections.append(WTFMove(request));
>         scheduleNextRejection();
>         return;

Actions: View | Formatted Diff | Diff

Attachments on bug 198575: 371425 | 371429